Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flake8-quotes] Deactivate Q000 in Q002-tests #10200

Closed

Conversation

robincaloudis
Copy link
Contributor

@robincaloudis robincaloudis commented Mar 2, 2024

Summary

During the work on #10199, I noticed that
the rule Q000 was used in tests that focus on
the behavior of docstring quotes (Q002).
As deactivation leads to more granular tests, this
change makes sure that the different test files
keep their focus in the long term and do not
start to test something unrelated. Furthermore,
this keeps snap files to the bare minimum.

Opening this PR,as I do not want to have this
changes in #10199, as both are logical unrelated
to each other.

Test Plan

Not needed. Will be implicitly tested.

Not needed. Deactivation leads
to more granular tests.
@robincaloudis robincaloudis changed the title [flake8-quotes] Deactivate Q000 in tests focusing on Q001 Q002 [flake8-quotes] Deactivate Q000 in tests focusing on Q001 and Q002 Mar 2, 2024
@robincaloudis robincaloudis changed the title [flake8-quotes] Deactivate Q000 in tests focusing on Q001 and Q002 [flake8-quotes] Deactivate Q000 in tests focusing on Q002 Mar 2, 2024
@robincaloudis robincaloudis changed the title [flake8-quotes] Deactivate Q000 in tests focusing on Q002 [flake8-quotes] Deactivate Q000 in Q002-tests Mar 2, 2024
@robincaloudis
Copy link
Contributor Author

@charliermarsh, do you mind to review this PR? Thank you.

Copy link
Contributor

github-actions bot commented Mar 2, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

ℹ️ ecosystem check encountered format errors. (no format changes; 1 project error)

openai/openai-cookbook (error)

warning: Detected debug build without --no-cache.
error: Failed to read examples/How_to_handle_rate_limits.ipynb: Expected a Jupyter Notebook, which must be internally stored as JSON, but this file isn't valid JSON: trailing comma at line 47 column 4

Formatter (preview)

ℹ️ ecosystem check encountered format errors. (no format changes; 1 project error)

openai/openai-cookbook (error)

ruff format --preview

warning: Detected debug build without --no-cache.
error: Failed to read examples/How_to_handle_rate_limits.ipynb: Expected a Jupyter Notebook, which must be internally stored as JSON, but this file isn't valid JSON: trailing comma at line 47 column 4

@charliermarsh
Copy link
Member

There is arguably some value here because it ensures that these rules aren't flagged in the docstring tests, right? I.e., that there are no false positives for Q000?

Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm reassigning this back to you, to reply to charlie's question.

@MichaReiser MichaReiser added the internal An internal refactor or improvement label Mar 6, 2024
@robincaloudis
Copy link
Contributor Author

I close this PR as I totally agree with the reviewers comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants