Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ruff] Expand rule for list(iterable).pop(0) idiom (RUF015) #10148

Merged
merged 6 commits into from Feb 28, 2024
Merged

[ruff] Expand rule for list(iterable).pop(0) idiom (RUF015) #10148

merged 6 commits into from Feb 28, 2024

Commits on Feb 27, 2024

  1. Reproduce lint rule limitation by a test 

    This little test makes sure that we have
something to test against when extending
the rule.
    @robincaloudis
    robincaloudis committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    be61cb3 View commit details
    Browse the repository at this point in the history

  2. Extend rule 

    This implementation makes the test
pass again.
    @robincaloudis
    robincaloudis committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    85700f2 View commit details
    Browse the repository at this point in the history

  3. Update doc

    @robincaloudis
    robincaloudis committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    ca9b2ab View commit details
    Browse the repository at this point in the history

  4. Add false-positive to test

    @robincaloudis
    robincaloudis committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    a73bd34 View commit details
    Browse the repository at this point in the history

  5. Filter for pop function

    @robincaloudis
    robincaloudis committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    2ce293a View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Fix range

    @charliermarsh
    charliermarsh committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    76d62d8 View commit details
    Browse the repository at this point in the history