Move D300 fix to preview

astral-sh · Oct 19, 2023 · c26ce2b · c26ce2b
1 parent 669558c
commit c26ce2b
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 13 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,7 +4,6 @@
 
 ### Rule changes
 - Add unsafe fix for `escape-sequence-in-docstring` (`D301`) (#7970)
-- Add fix for `triple-single-quotes` (`D300`) (#7967)
 
 ### Configuration
 - Respect `#(deprecated)` attribute in configuration options (#8035)
@@ -18,6 +17,7 @@
 - [`pylint`] Implement `misplaced-bare-raise` (`E0704`) (#7961)
 - [`pylint`] Implement `global-at-module-level` (`W0604`) (#8058)
 - [`pylint`] Implement `unspecified-encoding` (`PLW1514`) (#7939)
+- Add fix for `triple-single-quotes` (`D300`) (#7967)
 
 
 ### Formatter

diff --git a/crates/ruff_linter/src/rules/pydocstyle/rules/triple_quotes.rs b/crates/ruff_linter/src/rules/pydocstyle/rules/triple_quotes.rs
@@ -78,12 +78,14 @@ pub(crate) fn triple_quotes(checker: &mut Checker, docstring: &Docstring) {
                 let mut diagnostic =
                     Diagnostic::new(TripleSingleQuotes { expected_quote }, docstring.range());
 
-                let body = docstring.body().as_str();
-                if !body.ends_with('\'') {
-                    diagnostic.set_fix(Fix::safe_edit(Edit::range_replacement(
-                        format!("{prefixes}'''{body}'''"),
-                        docstring.range(),
-                    )));
+                if checker.settings.preview.is_enabled() {
+                    let body = docstring.body().as_str();
+                    if !body.ends_with('\'') {
+                        diagnostic.set_fix(Fix::safe_edit(Edit::range_replacement(
+                            format!("{prefixes}'''{body}'''"),
+                            docstring.range(),
+                        )));
+                    }
                 }
 
                 checker.diagnostics.push(diagnostic);
@@ -94,12 +96,14 @@ pub(crate) fn triple_quotes(checker: &mut Checker, docstring: &Docstring) {
                 let mut diagnostic =
                     Diagnostic::new(TripleSingleQuotes { expected_quote }, docstring.range());
 
-                let body = docstring.body().as_str();
-                if !body.ends_with('"') {
-                    diagnostic.set_fix(Fix::safe_edit(Edit::range_replacement(
-                        format!("{prefixes}\"\"\"{body}\"\"\""),
-                        docstring.range(),
-                    )));
+                if checker.settings.preview.is_enabled() {
+                    let body = docstring.body().as_str();
+                    if !body.ends_with('"') {
+                        diagnostic.set_fix(Fix::safe_edit(Edit::range_replacement(
+                            format!("{prefixes}\"\"\"{body}\"\"\""),
+                            docstring.range(),
+                        )));
+                    }
                 }
 
                 checker.diagnostics.push(diagnostic);