Fix D417 false positive (#3596)

astral-sh · Mar 18, 2023 · c21eb06 · c21eb06
1 parent 16a350c
commit c21eb06
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/crates/ruff/resources/test/fixtures/pydocstyle/D417.py b/crates/ruff/resources/test/fixtures/pydocstyle/D417.py
@@ -113,3 +113,13 @@ def f(x, *args, **kwargs):
         **kwargs: keyword arguments
     """
     return x
+
+
+class Test:
+    def f(self, /, arg1: int) -> None:
+        """
+        Some beauty description.
+
+        Args:
+            arg1: some description of arg
+        """
diff --git a/crates/ruff/src/rules/pydocstyle/rules/sections.rs b/crates/ruff/src/rules/pydocstyle/rules/sections.rs
@@ -804,9 +804,9 @@ fn missing_args(checker: &mut Checker, docstring: &Docstring, docstrings_args: &
     // Look for arguments that weren't included in the docstring.
     let mut missing_arg_names: FxHashSet<String> = FxHashSet::default();
     for arg in arguments
-        .args
+        .posonlyargs
         .iter()
-        .chain(arguments.posonlyargs.iter())
+        .chain(arguments.args.iter())
         .chain(arguments.kwonlyargs.iter())
         .skip(
             // If this is a non-static method, skip `cls` or `self`.