Merge branch 'main' into print-empty-string

crates/ruff_linter/resources/test/fixtures/flake8_bugbear/B009_B010.py

@@ -56,3 +56,7 @@
 
 # Regression test for: https://github.com/astral-sh/ruff/issues/7455#issuecomment-1722458885
 assert getattr(func, '_rpc')is True
+
+# Regression test for: https://github.com/astral-sh/ruff/issues/7455#issuecomment-1732387247
+getattr(*foo, "bar")
+setattr(*foo, "bar", None)

crates/ruff_linter/src/rules/flake8_bugbear/rules/getattr_with_constant.rs

@@ -64,6 +64,9 @@ pub(crate) fn getattr_with_constant(
     let [obj, arg] = args else {
         return;
     };
+    if obj.is_starred_expr() {
+        return;
+    }
     let Expr::Constant(ast::ExprConstant {
         value: Constant::Str(ast::StringConstant { value, .. }),
         ..
@@ -77,6 +80,9 @@ pub(crate) fn getattr_with_constant(
     if is_mangled_private(value) {
         return;
     }
+    if !checker.semantic().is_builtin("getattr") {
+        return;
+    }
 
     let mut diagnostic = Diagnostic::new(GetAttrWithConstant, expr.range());
     if checker.patch(diagnostic.kind.rule()) {

crates/ruff_linter/src/rules/flake8_bugbear/rules/setattr_with_constant.rs

@@ -78,6 +78,9 @@ pub(crate) fn setattr_with_constant(
     let [obj, name, value] = args else {
         return;
     };
+    if obj.is_starred_expr() {
+        return;
+    }
     let Expr::Constant(ast::ExprConstant {
         value: Constant::Str(name),
         ..
@@ -91,6 +94,10 @@ pub(crate) fn setattr_with_constant(
     if is_mangled_private(name) {
         return;
     }
+    if !checker.semantic().is_builtin("setattr") {
+        return;
+    }
+
     // We can only replace a `setattr` call (which is an `Expr`) with an assignment
     // (which is a `Stmt`) if the `Expr` is already being used as a `Stmt`
     // (i.e., it's directly within an `Stmt::Expr`).

crates/ruff_linter/src/rules/flake8_bugbear/snapshots/ruff_linter__rules__flake8_bugbear__tests__B009_B009_B010.py.snap

@@ -321,6 +321,8 @@ B009_B010.py:58:8: B009 [*] Do not call `getattr` with a constant attribute valu
 57 | # Regression test for: https://github.com/astral-sh/ruff/issues/7455#issuecomment-1722458885
 58 | assert getattr(func, '_rpc')is True
    |        ^^^^^^^^^^^^^^^^^^^^^ B009
+59 | 
+60 | # Regression test for: https://github.com/astral-sh/ruff/issues/7455#issuecomment-1732387247
    |
    = help: Replace `getattr` with attribute access
 
@@ -330,5 +332,8 @@ B009_B010.py:58:8: B009 [*] Do not call `getattr` with a constant attribute valu
 57 57 | # Regression test for: https://github.com/astral-sh/ruff/issues/7455#issuecomment-1722458885
 58    |-assert getattr(func, '_rpc')is True
    58 |+assert func._rpc is True
+59 59 | 
+60 60 | # Regression test for: https://github.com/astral-sh/ruff/issues/7455#issuecomment-1732387247
+61 61 | getattr(*foo, "bar")
 
 

crates/ruff_python_parser/src/lexer.rs

@@ -1656,7 +1656,7 @@ def f(arg=%timeit a = b):
     // This test case is to just make sure that the lexer doesn't go into
     // infinite loop on invalid input.
     #[test]
-    fn test_infite_loop() {
+    fn test_infinite_loop() {
         let source = "[1";
         let _ = lex(source, Mode::Module).collect::<Vec<_>>();
     }