Fix lack of not in PLC1901 error message (#3497)

astral-sh · Mar 13, 2023 · a82fe4a · a82fe4a
1 parent 62ff3b6
commit a82fe4a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/crates/ruff/src/rules/pylint/rules/compare_to_empty_string.rs b/crates/ruff/src/rules/pylint/rules/compare_to_empty_string.rs
@@ -34,8 +34,8 @@ impl TryFrom<&Cmpop> for EmptyStringCmpop {
 impl EmptyStringCmpop {
     pub fn into_unary(self) -> &'static str {
         match self {
-            Self::Is | Self::Eq => "",
-            Self::IsNot | Self::NotEq => "not ",
+            Self::Is | Self::Eq => "not ",
+            Self::IsNot | Self::NotEq => "",
         }
     }
 }

diff --git a/...ules/pylint/snapshots/ruff__rules__pylint__tests__PLC1901_compare_to_empty_string.py.snap b/...ules/pylint/snapshots/ruff__rules__pylint__tests__PLC1901_compare_to_empty_string.py.snap
@@ -4,7 +4,7 @@ expression: diagnostics
 ---
 - kind:
     name: CompareToEmptyString
-    body: "`x is \"\"` can be simplified to `x` as an empty string is falsey"
+    body: "`x is \"\"` can be simplified to `not x` as an empty string is falsey"
     suggestion: ~
     fixable: false
   location:
@@ -17,7 +17,7 @@ expression: diagnostics
   parent: ~
 - kind:
     name: CompareToEmptyString
-    body: "`x == \"\"` can be simplified to `x` as an empty string is falsey"
+    body: "`x == \"\"` can be simplified to `not x` as an empty string is falsey"
     suggestion: ~
     fixable: false
   location:
@@ -30,7 +30,7 @@ expression: diagnostics
   parent: ~
 - kind:
     name: CompareToEmptyString
-    body: "`y is not \"\"` can be simplified to `not y` as an empty string is falsey"
+    body: "`y is not \"\"` can be simplified to `y` as an empty string is falsey"
     suggestion: ~
     fixable: false
   location:
@@ -43,7 +43,7 @@ expression: diagnostics
   parent: ~
 - kind:
     name: CompareToEmptyString
-    body: "`y != \"\"` can be simplified to `not y` as an empty string is falsey"
+    body: "`y != \"\"` can be simplified to `y` as an empty string is falsey"
     suggestion: ~
     fixable: false
   location:
@@ -56,7 +56,7 @@ expression: diagnostics
   parent: ~
 - kind:
     name: CompareToEmptyString
-    body: "`\"\" != z` can be simplified to `not z` as an empty string is falsey"
+    body: "`\"\" != z` can be simplified to `z` as an empty string is falsey"
     suggestion: ~
     fixable: false
   location: