ignore _ assignments

astral-sh · Dec 24, 2023 · 6d1d0dd · 6d1d0dd
1 parent 4bbb3c4
commit 6d1d0dd
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/crates/ruff_linter/resources/test/fixtures/pylint/redeclared_assigned_name.py b/crates/ruff_linter/resources/test/fixtures/pylint/redeclared_assigned_name.py
@@ -3,4 +3,4 @@
 FIRST, (FIRST, SECOND, (THIRD, FIRST)) = (1, (1, 2))  # PLW0128
 FIRST, SECOND, THIRD, FIRST, SECOND = (1, 2, 3, 4)  # PLW0128
 
-FIRST, SECOND = (1, 2)  # OK
+FIRST, SECOND, _, _ = (1, 2, 3, 4)  # OK
diff --git a/crates/ruff_linter/src/rules/pylint/rules/redeclared_assigned_name.rs b/crates/ruff_linter/src/rules/pylint/rules/redeclared_assigned_name.rs
@@ -44,6 +44,10 @@ fn check_expr(checker: &mut Checker, expr: &Expr, names: &mut Vec<String>) {
             }
         }
         Expr::Name(ast::ExprName { id, .. }) => {
+            if id.to_string() == "_" {
+                // Ignore `_` assignments
+                return;
+            }
             if names.contains(&id.to_string()) {
                 checker.diagnostics.push(Diagnostic::new(
                     RedeclaredAssignedName {

diff --git a/...int/snapshots/ruff_linter__rules__pylint__tests__PLW0128_redeclared_assigned_name.py.snap b/...int/snapshots/ruff_linter__rules__pylint__tests__PLW0128_redeclared_assigned_name.py.snap
@@ -43,7 +43,7 @@ redeclared_assigned_name.py:4:23: PLW0128 Redeclared variable `FIRST` in assignm
 4 | FIRST, SECOND, THIRD, FIRST, SECOND = (1, 2, 3, 4)  # PLW0128
   |                       ^^^^^ PLW0128
 5 | 
-6 | FIRST, SECOND = (1, 2)  # OK
+6 | FIRST, SECOND, _, _ = (1, 2, 3, 4)  # OK
   |
 
 redeclared_assigned_name.py:4:30: PLW0128 Redeclared variable `SECOND` in assignment
@@ -53,7 +53,7 @@ redeclared_assigned_name.py:4:30: PLW0128 Redeclared variable `SECOND` in assign
 4 | FIRST, SECOND, THIRD, FIRST, SECOND = (1, 2, 3, 4)  # PLW0128
   |                              ^^^^^^ PLW0128
 5 | 
-6 | FIRST, SECOND = (1, 2)  # OK
+6 | FIRST, SECOND, _, _ = (1, 2, 3, 4)  # OK
   |