Fix infinite loop due to rules D207 & W605

astral-sh · Mar 19, 2023 · 4604778 · 4604778
1 parent de1106b
commit 4604778
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 17 deletions.
diff --git a/crates/ruff/src/rules/pycodestyle/rules/invalid_escape_sequence.rs b/crates/ruff/src/rules/pycodestyle/rules/invalid_escape_sequence.rs
@@ -114,7 +114,10 @@ pub fn invalid_escape_sequence(
                     Range::new(location, end_location),
                 );
                 if autofix {
-                    diagnostic.amend(Fix::insertion(r"\".to_string(), location));
+                    diagnostic.amend(Fix::insertion(
+                        r"\".to_string(),
+                        Location::new(location.row(), location.column() + 1),
+                    ));
                 }
                 diagnostics.push(diagnostic);
             }

diff --git a/...ruff/src/rules/pycodestyle/snapshots/ruff__rules__pycodestyle__tests__W605_W605_0.py.snap b/...ruff/src/rules/pycodestyle/snapshots/ruff__rules__pycodestyle__tests__W605_W605_0.py.snap
@@ -17,10 +17,10 @@ expression: diagnostics
     content: "\\"
     location:
       row: 2
-      column: 9
+      column: 10
     end_location:
       row: 2
-      column: 9
+      column: 10
   parent: ~
 - kind:
     name: InvalidEscapeSequence
@@ -37,10 +37,10 @@ expression: diagnostics
     content: "\\"
     location:
       row: 6
-      column: 0
+      column: 1
     end_location:
       row: 6
-      column: 0
+      column: 1
   parent: ~
 - kind:
     name: InvalidEscapeSequence
@@ -57,10 +57,10 @@ expression: diagnostics
     content: "\\"
     location:
       row: 11
-      column: 5
+      column: 6
     end_location:
       row: 11
-      column: 5
+      column: 6
   parent: ~
 - kind:
     name: InvalidEscapeSequence
@@ -77,9 +77,9 @@ expression: diagnostics
     content: "\\"
     location:
       row: 18
-      column: 5
+      column: 6
     end_location:
       row: 18
-      column: 5
+      column: 6
   parent: ~
 
diff --git a/...ruff/src/rules/pycodestyle/snapshots/ruff__rules__pycodestyle__tests__W605_W605_1.py.snap b/...ruff/src/rules/pycodestyle/snapshots/ruff__rules__pycodestyle__tests__W605_W605_1.py.snap
@@ -17,10 +17,10 @@ expression: diagnostics
     content: "\\"
     location:
       row: 2
-      column: 9
+      column: 10
     end_location:
       row: 2
-      column: 9
+      column: 10
   parent: ~
 - kind:
     name: InvalidEscapeSequence
@@ -37,10 +37,10 @@ expression: diagnostics
     content: "\\"
     location:
       row: 6
-      column: 0
+      column: 1
     end_location:
       row: 6
-      column: 0
+      column: 1
   parent: ~
 - kind:
     name: InvalidEscapeSequence
@@ -57,10 +57,10 @@ expression: diagnostics
     content: "\\"
     location:
       row: 11
-      column: 5
+      column: 6
     end_location:
       row: 11
-      column: 5
+      column: 6
   parent: ~
 - kind:
     name: InvalidEscapeSequence
@@ -77,9 +77,9 @@ expression: diagnostics
     content: "\\"
     location:
       row: 18
-      column: 5
+      column: 6
     end_location:
       row: 18
-      column: 5
+      column: 6
   parent: ~