Skip to content

Commit

Permalink
Remove build from the default exclusion list (#10093)
Browse files Browse the repository at this point in the history
## Summary

This is a not-unpopular directory name, and it's led to tons of issues
and user confusion (most recently:
astral-sh/ruff-pre-commit#69). I've wanted to
remove it for a long time, but we need to do so as part of a minor
release.
  • Loading branch information
charliermarsh committed Feb 28, 2024
1 parent 8044c24 commit 317d2e4
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ file_resolver.exclude = [
"__pypackages__",
"_build",
"buck-out",
"build",
"dist",
"node_modules",
"site-packages",
Expand Down Expand Up @@ -366,4 +365,3 @@ formatter.docstring_code_format = disabled
formatter.docstring_code_line_width = dynamic

----- stderr -----

2 changes: 1 addition & 1 deletion crates/ruff_workspace/src/options.rs
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ pub struct Options {
/// Note that you'll typically want to use
/// [`extend-exclude`](#extend-exclude) to modify the excluded paths.
#[option(
default = r#"[".bzr", ".direnv", ".eggs", ".git", ".git-rewrite", ".hg", ".mypy_cache", ".nox", ".pants.d", ".pytype", ".ruff_cache", ".svn", ".tox", ".venv", "__pypackages__", "_build", "buck-out", "build", "dist", "node_modules", "venv"]"#,
default = r#"[".bzr", ".direnv", ".eggs", ".git", ".git-rewrite", ".hg", ".mypy_cache", ".nox", ".pants.d", ".pytype", ".ruff_cache", ".svn", ".tox", ".venv", "__pypackages__", "_build", "buck-out", "dist", "node_modules", "venv"]"#,
value_type = "list[str]",
example = r#"
exclude = [".venv"]
Expand Down
1 change: 0 additions & 1 deletion crates/ruff_workspace/src/settings.rs
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,6 @@ pub(crate) static EXCLUDE: &[FilePattern] = &[
FilePattern::Builtin("__pypackages__"),
FilePattern::Builtin("_build"),
FilePattern::Builtin("buck-out"),
FilePattern::Builtin("build"),
FilePattern::Builtin("dist"),
FilePattern::Builtin("node_modules"),
FilePattern::Builtin("site-packages"),
Expand Down

0 comments on commit 317d2e4

Please sign in to comment.