Convert literal-membership to a safe edit

astral-sh · Jan 29, 2024 · 1c8db54 · 1c8db54
1 parent 0045032
commit 1c8db54
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/crates/ruff_linter/src/rules/pylint/rules/literal_membership.rs b/crates/ruff_linter/src/rules/pylint/rules/literal_membership.rs
@@ -59,10 +59,7 @@ pub(crate) fn literal_membership(checker: &mut Checker, compare: &ast::ExprCompa
 
     let literal = checker.locator().slice(right);
     let set = format!("{{{}}}", &literal[1..literal.len() - 1]);
-    diagnostic.set_fix(Fix::unsafe_edit(Edit::range_replacement(
-        set,
-        right.range(),
-    )));
+    diagnostic.set_fix(Fix::safe_edit(Edit::range_replacement(set, right.range())));
 
     checker.diagnostics.push(diagnostic);
 }
diff --git a/...es/pylint/snapshots/ruff_linter__rules__pylint__tests__PLR6201_literal_membership.py.snap b/...es/pylint/snapshots/ruff_linter__rules__pylint__tests__PLR6201_literal_membership.py.snap
@@ -11,7 +11,7 @@ literal_membership.py:2:6: PLR6201 [*] Use a `set` literal when testing for memb
   |
   = help: Convert to `set`
 
-ℹ Unsafe fix
+ℹ Safe fix
 1 1 | # Errors
 2   |-1 in [1, 2, 3]
   2 |+1 in {1, 2, 3}
@@ -30,7 +30,7 @@ literal_membership.py:3:6: PLR6201 [*] Use a `set` literal when testing for memb
   |
   = help: Convert to `set`
 
-ℹ Unsafe fix
+ℹ Safe fix
 1 1 | # Errors
 2 2 | 1 in [1, 2, 3]
 3   |-1 in (1, 2, 3)
@@ -53,7 +53,7 @@ literal_membership.py:4:6: PLR6201 [*] Use a `set` literal when testing for memb
   |
   = help: Convert to `set`
 
-ℹ Unsafe fix
+ℹ Safe fix
 1 1 | # Errors
 2 2 | 1 in [1, 2, 3]
 3 3 | 1 in (1, 2, 3)