Code review

crates/ruff_linter/resources/test/fixtures/pylint/invalid_return_type_bytes.py

@@ -12,6 +12,10 @@ class Str:
     def __bytes__(self):
         return "some bytes"  # [invalid-bytes-return]
 
+class BytesNoReturn:
+    def __bytes__(self):
+        print("ruff")  # [invalid-bytes-return]
+
 # TODO: Once Ruff has better type checking
 def return_bytes():
     return "some string"

crates/ruff_linter/src/rules/pylint/rules/invalid_bytes_return.rs

@@ -57,6 +57,13 @@ pub(crate) fn invalid_bytes_return(checker: &mut Checker, name: &str, body: &[St
         visitor.returns
     };
 
+    if returns.is_empty() {
+        checker.diagnostics.push(Diagnostic::new(
+            InvalidBytesReturnType,
+            body.last().unwrap().range(),
+        ));
+    }
+
     for stmt in returns {
         if let Some(value) = stmt.value.as_deref() {
             if !matches!(

crates/ruff_linter/src/rules/pylint/snapshots/ruff_linter__rules__pylint__tests__PLE0308_invalid_return_type_bytes.py.snap

@@ -28,5 +28,15 @@ invalid_return_type_bytes.py:13:16: PLE0308 `__bytes__` does not return `bytes`
 13 |         return "some bytes"  # [invalid-bytes-return]
    |                ^^^^^^^^^^^^ PLE0308
 14 | 
-15 | # TODO: Once Ruff has better type checking
+15 | class BytesNoReturn:
+   |
+
+invalid_return_type_bytes.py:17:9: PLE0308 `__bytes__` does not return `bytes`
+   |
+15 | class BytesNoReturn:
+16 |     def __bytes__(self):
+17 |         print("ruff")  # [invalid-bytes-return]
+   |         ^^^^^^^^^^^^^ PLE0308
+18 | 
+19 | # TODO: Once Ruff has better type checking
    |