Consider not using --force-exclude by default #69
Comments
schlerp
added a commit
to schlerp/ruff-pre-commit
that referenced
this issue
Feb 23, 2024
Updates README.md to include a warning about the default choice of `--force-exclude` being used by the github action. This warning includes links to the documentation for these settings. Addresses astral-sh#69
|
Agreed, this has recently caught me out too, i think the best option is to just add it to the readme for now. Its trivial to remove if we do make the decision to drop it as a default argument. I have submitted a PR for this here: #72 |
|
Alternatively, I'm going to remove |
|
See: astral-sh/ruff#10093. |
|
Yeah that makes sense :) Do we still think it's worth mentioning its the default? I spent quite a bit of time digging into this and really would have appreciated it being pointed out in the README 😆 |
charliermarsh
added a commit
to astral-sh/ruff
that referenced
this issue
Feb 28, 2024
## Summary This is a not-unpopular directory name, and it's led to tons of issues and user confusion (most recently: astral-sh/ruff-pre-commit#69). I've wanted to remove it for a long time, but we need to do so as part of a minor release.
nkxxll
pushed a commit
to nkxxll/ruff
that referenced
this issue
Mar 10, 2024
## Summary This is a not-unpopular directory name, and it's led to tons of issues and user confusion (most recently: astral-sh/ruff-pre-commit#69). I've wanted to remove it for a long time, but we need to do so as part of a minor release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Contrary to #19, making
--force-excludean implicit default can cause confusing behaviors. As some CI environments might run under paths that are excluded by default or excluded by custom configuration.For example, the Bitbucket pipeline runs under
/opt/atlassian/pipelines/agent/build, which is excluded by default (build), so runningpre-commit run --all-filestakes no effect at all, but it totally works as expected under local repo, really confusing!Take me quite some time to figure out why our CI is not working, apparently, others have the same problem.
I suggest making the
--force-excludean opt-in, or at least add a reminder in README for setting--no-force-exclude.The text was updated successfully, but these errors were encountered: