Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hasNullValue and doesNotHaveNullValue to AtomicReferenceAssert #2969

Closed
Closed
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -163,4 +163,40 @@ public AtomicReferenceAssert<V> hasValueSatisfying(Consumer<? super V> requireme
return myself;
}

/**
* Verifies that the atomic under test has the {@code null} value.
* <p>
* Example:
* <pre><code class='java'> // assertion succeeds
* assertThat(new AtomicReference(null)).hasNullValue();
*
* // assertion fails
* assertThat(new AtomicReference("foo")).hasNullValue();</code></pre>
*
* @return {@code this} assertion object.
* @throws AssertionError if the atomic under test does not have the null value.
* @since 3.25.0
*/
public AtomicReferenceAssert<V> hasNullValue() {
return hasValue(null);
}

/**
* Verifies that the atomic under test does not have the {@code null} value.
* <p>
* Example:
* <pre><code class='java'> // assertion succeeds
* assertThat(new AtomicReference("foo")).doesNotHaveNullValue();
*
* // assertion fails
* assertThat(new AtomicReference(null)).doesNotHaveNullValue();</code></pre>
*
* @return {@code this} assertion object.
* @throws AssertionError if the atomic under test has the null value.
* @since 3.25.0
*/
public AtomicReferenceAssert<V> doesNotHaveNullValue() {
return doesNotHaveValue(null);
}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
/*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on
* an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the
* specific language governing permissions and limitations under the License.
*
* Copyright 2012-2023 the original author or authors.
*/
package org.assertj.core.api.atomic.reference;

import org.junit.jupiter.api.Test;

import java.util.concurrent.atomic.AtomicReference;

import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
import static org.assertj.core.error.ShouldNotContainValue.shouldNotContainValue;

class AtomicReferenceAssert_doesNotHaveNullValue_Test {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you follow the testing guidelines documented in https://github.com/assertj/assertj/blob/main/CONTRIBUTING.md notably using GIVEN WHEN THEN and AssertionUtil.expectAssertionError.

this comment applies to the other test too, thanks!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!! thanks.


@Test
void should_pass_when_actual_does_not_have_the_null_value() {
AtomicReference<String> actual = new AtomicReference<>("foo");
assertThat(actual).doesNotHaveNullValue();
}

@Test
void should_fail_when_actual_has_the_null_value() {
AtomicReference<String> actual = new AtomicReference<>(null);
assertThatExceptionOfType(AssertionError.class).isThrownBy(() -> assertThat(actual).doesNotHaveNullValue())
.withMessage(shouldNotContainValue(actual, null).create());
}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
/*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on
* an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the
* specific language governing permissions and limitations under the License.
*
* Copyright 2012-2023 the original author or authors.
*/
package org.assertj.core.api.atomic.reference;

import org.junit.jupiter.api.Test;

import java.util.concurrent.atomic.AtomicReference;

import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
import static org.assertj.core.error.ShouldHaveValue.shouldHaveValue;

class AtomicReferenceAssert_hasNullValue_Test {

@Test
void should_pass_when_actual_has_the_null_value() {
AtomicReference<String> actual = new AtomicReference<>(null);
assertThat(actual).hasNullValue();
}

@Test
void should_fail_when_actual_does_not_have_the_null_value() {
AtomicReference<String> actual = new AtomicReference<>("foo");
assertThatExceptionOfType(AssertionError.class).isThrownBy(() -> assertThat(actual).hasNullValue())
.withMessage(shouldHaveValue(actual, null).create());
}

}