Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stdin): Provide a Command wrapper #85

Merged
merged 2 commits into from
Dec 5, 2019
Merged

fix(stdin): Provide a Command wrapper #85

merged 2 commits into from
Dec 5, 2019

Conversation

epage
Copy link
Contributor

@epage epage commented Dec 5, 2019

Many of our problems with stdin are derived from using extension
traits. By moving away from them, we fix the API problems and make it
easier to add other features like timeout (#10) or signalling (#84).

So the new philosphy if:

  • Core functionality is provided by extension traits
  • Provide a convinience API that makes Command friendlier. These do
    not need to be generalized. Other abstractions can provide their own
    (like duct).

Fixes #73

Ed Page added 2 commits December 5, 2019 10:44
BREAKING CHANGE: `assert_cmd::cmd` was renamed to `assert_cmd::output`.
Many of our problems with `stdin` are derived from using extension
traits. By moving away from them, we fix the API problems and make it
easier to add other features like timeout (assert-rs#10) or signalling (assert-rs#84).

So the new philosphy if:
- Core functionality is provided by extension traits
- Provide a convinience API that makes `Command` friendlier. These do
  not need to be generalized.  Other abstractions can provide their own
  (like `duct`).

Fixes assert-rs#73
@epage epage merged commit fdf9cd3 into assert-rs:master Dec 5, 2019
@epage epage deleted the 10 branch December 5, 2019 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stdin handling is an unfriendly API
1 participant