Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pnpm workspace example in docs to avoid edge cases #2111

Merged
merged 3 commits into from
Feb 27, 2025

Conversation

sbussard
Copy link
Contributor

The previous approach does not seem stable .

It was working with initial tests but now it's not, and I'd hate for someone to encounter this sort of snag based on my contribution.

Here's the type of error I was seeing

RR_PNPM_WORKSPACE_PKG_NOT_FOUND  In ../../../../../../../../external/aspect_rules_js+/js/private/test/image: "@mycorp/pkg-a@workspace:*" is in the dependencies but no package named "@mycorp/pkg-a" is present in the workspace

This happens if you add anything like - './**/*' , - '**' , or - '*' to workspace packages. It doesn't seem to matter if you have - !.. , it still tries to look there.

So this new approach is to manually add project dirs and their subfolders. Easy enough.

- 'experimental/**'
- 'users/**'
- 'some_deeply_nested_project/**'

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link

aspect-workflows bot commented Feb 23, 2025

Test

All tests were cache hits

213 tests (100.0%) were fully cached saving 32s.


Test

e2e/bzlmod

All tests were cache hits

5 tests (100.0%) were fully cached saving 502ms.


Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 200ms.


Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 8s.


Test

e2e/npm_link_package

All tests were cache hits

3 tests (100.0%) were fully cached saving 302ms.


Test

e2e/npm_link_package-esm

All tests were cache hits

3 tests (100.0%) were fully cached saving 387ms.


Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 30ms.


Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 30ms.


Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 268ms.


Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Test

e2e/npm_translate_lock_replace_packages

All tests were cache hits

3 tests (100.0%) were fully cached saving 608ms.


Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 98ms.


Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 253ms.


Test

e2e/pnpm_lockfiles

All tests were cache hits

42 tests (100.0%) were fully cached saving 3s.


Test

e2e/pnpm_workspace

All tests were cache hits

10 tests (100.0%) were fully cached saving 2s.


Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

12 tests (100.0%) were fully cached saving 2s.


Test

e2e/repo_mapping

All tests were cache hits

2 tests (100.0%) were fully cached saving 198ms.


Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 202ms.


Test

e2e/runfiles

All tests were cache hits

1 test (100.0%) was fully cached saving 173ms.


Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 99ms.


Buildifier      Format

@sbussard
Copy link
Contributor Author

This error could be due to the fact that I had removed verify_node_modules_ignored = "//:.bazelignore"

https://bazelbuild.slack.com/archives/CEZUUKQ6P/p1739851043050399

But this PR is here just in case the problem is something else.
I'll let the team decide what's best

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@jbedard jbedard merged commit 05882fc into aspect-build:main Feb 27, 2025
99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants