Optimize FieldLocation #1
Conversation
schlosna
force-pushed
the
aash/usingRecursiveComparison-slowness-repro
branch
2 times, most recently
from
eca8471
to
159ad26
Compare
| @@ -33,7 +36,7 @@ public final class FieldLocation implements Comparable<FieldLocation> { | |||
|
|
|||
| private final String pathToUseInRules; | |||
| private final List<String> decomposedPath; | |||
| private final List<String> pathsHierarchyToUseInRules; | |||
| private final Set<String> pathsHierarchyToUseInRules; | |||
There was a problem hiding this comment.
provide O(1) contains instead of O(N) for List#contains used by hierarchyMatches(String)
| @@ -163,7 +166,10 @@ public boolean equals(Object obj) { | |||
|
|
|||
| @Override | |||
| public int hashCode() { | |||
| return Objects.hash(pathToUseInRules, decomposedPath, pathsHierarchyToUseInRules); | |||
There was a problem hiding this comment.
minor improvement to avoid implicit Object[] allocation from Objects.hash
| List<String> parentPath = new ArrayList<>(decomposedPath); | ||
| parentPath.remove(decomposedPath.size() - 1); | ||
| return new FieldLocation(parentPath); |
There was a problem hiding this comment.
This was allocating a lot of ArrayList and FieldLocation. I had tried return new FieldLocation(decomposedPath.subList(0, decomposedPath.size() - 1)); but that still allocates O(N) FieldLocation as pathsHierarchyToUseInRules traverses the node's path to root.
There was a problem hiding this comment.
we could simplify the hash code by only using pathToUseInRules since the fields are more or less variations of that information
There was a problem hiding this comment.
good call, String#hashCode() is memoized and much less expensive than also including List<String>#hashCode() and Set<String>#hashCode() which are each O(N)
There was a problem hiding this comment.
Going to adjust this to satisfy equals verifier error
-> Significant fields: equals relies on decomposedPath, but hashCode does not.
FieldLocation maintains set of paths to use in rules ordered from leaf to parent. The set provides O(1) hierarchyMatches operation.
schlosna
force-pushed
the
aash/usingRecursiveComparison-slowness-repro
branch
from
159ad26
to
f9b759a
Compare
FieldLocation maintains set of paths to use in rules ordered from leaf to parent. The set provides O(1) hierarchyMatches operation.
This addresses the following trace from JFR running some test cases using assertj 3.25.2 using
usingRecursiveComparison().isEqualToCheck List: