Skip to content

Commit

Permalink
Changing clang-tidy-review to v0.14.0 to see if it works
Browse files Browse the repository at this point in the history
v0.17.1 looks buggy to download artifacts, even with this patch:

  ZedThree/clang-tidy-review#115

We got the following error:

  File "/usr/local/lib/python3.12/site-packages/clang_tidy_review/post.py", line 80, in main
    metadata, review = download_artifacts(pull_request, int(args.workflow_id))
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/clang_tidy_review/__init__.py", line 946, in download_artifacts
    contents = b"".join(data["data"].iter_content())
                        ~~~~^^^^^^^^
TypeError: 'NoneType' object is not subscriptable
  • Loading branch information
dacap committed Feb 27, 2024
1 parent f8dde51 commit 88c3cb7
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/clang_tidy.yml
Expand Up @@ -16,7 +16,7 @@ jobs:
- uses: actions/checkout@v4
with:
submodules: 'recursive'
- uses: ZedThree/clang-tidy-review@v0.17.1
- uses: ZedThree/clang-tidy-review@v0.14.0
id: review
with:
build_dir: build
Expand All @@ -28,5 +28,5 @@ jobs:
libxcursor-dev, libxi-dev, libgl1-mesa-dev
cmake_command: |
cmake -S . -B build -DCMAKE_BUILD_TYPE=Debug -DLAF_BACKEND=none -DCMAKE_EXPORT_COMPILE_COMMANDS=on
- uses: ZedThree/clang-tidy-review/upload@v0.17.1
- uses: ZedThree/clang-tidy-review/upload@v0.14.0
id: upload-review
2 changes: 1 addition & 1 deletion .github/workflows/clang_tidy_post.yml
Expand Up @@ -13,6 +13,6 @@ jobs:
post-comments:
runs-on: ubuntu-latest
steps:
- uses: ZedThree/clang-tidy-review/post@9a32adc734e10e4d84baa60f2b7d7c021568c527
- uses: ZedThree/clang-tidy-review/post@v0.14.0
with:
token: ${{ secrets.CLANG_TIDY_TOKEN }}

0 comments on commit 88c3cb7

Please sign in to comment.