Skip to content

Commit

Permalink
Set Java 11 as minimal version (#653)
Browse files Browse the repository at this point in the history
* Update maven-compiler-plugin to use 'release'
* Remove Java8 from CI
* Add info to migration guide

Closes #652
  • Loading branch information
abelsromero committed Jun 15, 2023
1 parent b6b0556 commit 446f079
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 5 deletions.
1 change: 0 additions & 1 deletion .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ jobs:
- windows-latest
- macos-latest
java:
- 8
- 11
- 17
# Support for 1 year old version
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ Improvements::
Build / Infrastructure::

* Fix maven-source-plugin configuration for releases (#644)
* Set Java 11 as minimal version (remove Java8 support) (#652)

Documentation::

Expand Down
11 changes: 10 additions & 1 deletion docs/modules/plugin/pages/v3-migration-guide.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,18 @@ Users of the site module see xref:site-integration:v3-migration-guide.adoc[v3 mi

== Changes

=== Minimal Java version

Minimal Java version is 11.

For anyone in need of a Java 8 compatible release, v2.5.x of the plugin will be supported for some time after v3.0.x release.
Note this also imposes versions on dependencies, for example:
* Only AsciidoctorJ v2.5.x
* Only asciidoctorj-diagram previous v2.2.8

=== Minimal AsciidoctorJ version

Support for Asciidoctorj v1.6.x (released 14th Feb, 2019) has been totally removed and will fail when configured.
Support for AsciidoctorJ v1.6.x (released 14th Feb, 2019) has been totally removed and will fail when configured.
This simplifies the current plugin code and allows for removal of Java reflection usage.

*If you are setting the AsciidoctorJ dependency directly, ensure it's v2.0.0 or higher*.
Expand Down
5 changes: 2 additions & 3 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.java.version>1.8</project.java.version>
<project.java.version>11</project.java.version>
<project.execution.environment>JavaSE-1.8</project.execution.environment>
<asciidoctorj.version>2.5.10</asciidoctorj.version>
<jruby.version>9.4.2.0</jruby.version>
Expand Down Expand Up @@ -147,8 +147,7 @@
<artifactId>maven-compiler-plugin</artifactId>
<version>3.11.0</version>
<configuration>
<source>${project.java.version}</source>
<target>${project.java.version}</target>
<release>${project.java.version}</release>
</configuration>
</plugin>
</plugins>
Expand Down

0 comments on commit 446f079

Please sign in to comment.