Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated numerous action revisions #7590

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

xavier2k6
Copy link
Contributor

Addresses some but not all github action warnings below. (Others require upstream changes)

Node.js 16 actions are deprecated.
https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

CodeQL Action v2 will be deprecated on December 5th, 2024.
https://github.blog/changelog/2024-01-12-code-scanning-deprecation-of-codeql-action-v2/

@userdocs

This comment was marked as resolved.

@xavier2k6

This comment was marked as outdated.

@xavier2k6 xavier2k6 marked this pull request as draft January 29, 2024 10:37
@xavier2k6 xavier2k6 force-pushed the lbt_ci_actions branch 8 times, most recently from fc8f955 to 26da22d Compare February 9, 2024 21:53
@xavier2k6
Copy link
Contributor Author

xavier2k6 commented Feb 9, 2024

There are issues with naming artifacts which were highlighted when changing some github actions to v4, mostly in cibuildwheel workflow, I will hopefully be able to take care of these in a separate PR

I took care of the one in linux workflow

@xavier2k6
Copy link
Contributor Author

@arvidn cibuildwheel/windows fails.....unsure of how to resolve this issue (module missing?), other than that this PR is complete.

@xavier2k6 xavier2k6 marked this pull request as ready for review February 21, 2024 15:25
@xavier2k6
Copy link
Contributor Author

@arvidn I've marked this for review....I'll leave it up to you how you'd like to proceed with the cibuildwheel failure

Copy link
Owner

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the windows python build seems unrelated to this

@arvidn arvidn merged commit 4ef2211 into arvidn:RC_2_0 Feb 21, 2024
48 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants