Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(phoneinput): fixes for dark mode #1385

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

dzucconi
Copy link
Member

  • Fixes for dark mode
  • Fixes border color to align with spec

@dzucconi dzucconi requested a review from MrSltun May 29, 2024 11:57
@dzucconi dzucconi self-assigned this May 29, 2024
@@ -445,6 +445,7 @@ const SelectOption = styled(Box)<{ selected?: boolean }>`

const StyledInput = styled.input`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering why we didn't just use a Palette input here so that these don't drift. Alternatively could have extracted a mixin. This will probably crop up again as a problem area.

@dzucconi dzucconi enabled auto-merge May 29, 2024 11:58
@dzucconi dzucconi merged commit 28871ae into main May 29, 2024
9 of 10 checks passed
@dzucconi dzucconi deleted the dzucconi/fix/phone-input branch May 29, 2024 11:59
@artsyit
Copy link
Contributor

artsyit commented May 29, 2024

🚀 PR was released in @artsy/palette-charts@37.11.1, @artsy/palette@38.11.1 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants