Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removes deprecated modal and dialog #1308

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

dzucconi
Copy link
Member

@dzucconi dzucconi commented Aug 9, 2023

BREAKING CHANGE: Modal and Dialog components are to be replaced with ModalDialog

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @artsy/palette-charts@34.0.0-canary.1308.28344.0
npm install @artsy/palette@35.0.0-canary.1308.28344.0
# or 
yarn add @artsy/palette-charts@34.0.0-canary.1308.28344.0
yarn add @artsy/palette@35.0.0-canary.1308.28344.0

Verified

This commit was signed with the committer’s verified signature.
bchavez Brian Chavez
BREAKING CHANGE: `Modal` and `Dialog` components are to be replaced with `ModalDialog`
@dzucconi dzucconi added Version: Major canary Publish a canary for this PR labels Aug 9, 2023
@dzucconi dzucconi requested a review from damassi August 9, 2023 17:54
@dzucconi dzucconi self-assigned this Aug 9, 2023
@dzucconi
Copy link
Member Author

dzucconi commented Aug 9, 2023

OK, this looks good in Force. There were 2 instances of ModalWidth.Wide (which is just 900); which is weird and I'll just replace when I bump the dep.

@dzucconi dzucconi merged commit 273e365 into main Aug 9, 2023
@dzucconi dzucconi deleted the dzucconi/chore/removes-old-modal branch August 9, 2023 18:08
@artsyit
Copy link
Contributor

artsyit commented Aug 9, 2023

🚀 PR was released in @artsy/palette-charts@34.0.0, @artsy/palette@35.0.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
canary Publish a canary for this PR released Version: Major
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants