Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update fastlane for google api instability workaround #9297

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

brainbicycle
Copy link
Contributor

This PR resolves []

Description

Fastlane added a workaround for some of the google API failures we are seeing!

We can pass this env var to retry if we continue to see issues:
fastlane/fastlane#21518

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 馃憖

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

  • update fastlane for google api fix - Brian

Need help with something? Have a look at our docs, or get in touch with us.

@brainbicycle brainbicycle changed the title chore: update fastlane for google api instability fix chore: update fastlane for google api instability workaround Sep 20, 2023
@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Sep 20, 2023

This PR contains the following changes:

  • Dev changes (update fastlane for google api fix - Brian)

Generated by 馃毇 dangerJS against 27bd4b4

@brainbicycle
Copy link
Contributor Author

hmm I think I am messing up our gem file with my bundler version, WIP til I fix.

@brainbicycle brainbicycle marked this pull request as draft September 21, 2023 13:24
@brainbicycle brainbicycle marked this pull request as ready for review September 22, 2023 13:32
Copy link
Member

@gkartalis gkartalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brainbicycle brainbicycle merged commit f0b572b into main Sep 22, 2023
9 checks passed
@brainbicycle brainbicycle deleted the brian/update-fastlane branch September 22, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants