Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: saved alerts events #450

Merged
merged 2 commits into from
Aug 31, 2023
Merged

fix: saved alerts events #450

merged 2 commits into from
Aug 31, 2023

Conversation

lidimayra
Copy link
Contributor

@lidimayra lidimayra commented Aug 31, 2023

The type of this PR is: FIX

Slack thread
Relates to #448

Description

Fixes issues that are leading the build to fail

PR Checklist (tick all before merging)

  • If I've added a new file to the tree I've exported it from the common index.ts
  • I've added comments with examples for any new interfaces and ensured that they're in the docs
  • No platform-specific terminology has been used outside of click and tap (platform is inferred by the DB storing events)

@lidimayra lidimayra self-assigned this Aug 31, 2023
@artsy-peril artsy-peril bot added Jira Synced Indicates that Peril has connected this PR to Jira Version: Minor A deploy for new features labels Aug 31, 2023
Copy link
Contributor

@tam-kis tam-kis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, the error message was also pointing to this - thanks! 👍

@lidimayra lidimayra merged commit a792015 into main Aug 31, 2023
@lidimayra lidimayra deleted the lidimayra/fix-saved-alerts-events branch August 31, 2023 09:43
@artsyit
Copy link
Collaborator

artsyit commented Aug 31, 2023

🚀 PR was released in v4.137.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jira Synced Indicates that Peril has connected this PR to Jira released Version: Minor A deploy for new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants