fix(fargate): start workers in parallel with lead task #2459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts the behavior introduced in [1] where worker tasks may wait for up to 60s whilst the lead task is preparing npm dependencies. The only benefit of waiting is to save up to 60s worth of Fargate compute costs for tests where the lead task fails to startup. This is rare. Every test pays a penalty of having to wait for some time for the lead task to be ready before the rest of the workers even begin initializing however. 1. #2428
|
Failing test is due to AWS Lambda zip size bug fixed in #2457 |
This was referenced Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the behavior introduced in [1] where worker tasks may wait for up to 60s whilst the lead task is preparing npm dependencies.
The only benefit of waiting is to save up to 60s worth of Fargate compute costs for tests where the lead task fails to startup. This is rare.
Every test pays a penalty of having to wait for some time for the lead task to be ready before the rest of the workers even begin initializing however.