feat(fargate): set cloudwatch logs retention policy #2446
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up of #2434
This sets retention policy for Cloudwatch logs. It sets an interval with a max number of retries to set the policy, so this isn't a blocking step and doesn't add additional time to the test unless something goes wrong.
Things that need review:
LOGGROUP_RETENTION_DAYS
time should be.. Technically this is a change that could break workflows, if people are expecting a certain retention period. I put 6 months for now, but let's decide on the ideal time.process.env.ARTILLERY_LOGGROUP_RETENTION
environment variable so that this can be overridden. We may want this to be exposed in some other way, but for now it felt like a reasonable way to do it.Pre-merge checklist