Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fargate): set cloudwatch logs retention policy #2446

Conversation

bernardobridge
Copy link
Contributor

Description

Follow up of #2434

This sets retention policy for Cloudwatch logs. It sets an interval with a max number of retries to set the policy, so this isn't a blocking step and doesn't add additional time to the test unless something goes wrong.

Things that need review:

  • Wasn't sure what was the ideal LOGGROUP_RETENTION_DAYS time should be.. Technically this is a change that could break workflows, if people are expecting a certain retention period. I put 6 months for now, but let's decide on the ideal time.
  • I exposed the process.env.ARTILLERY_LOGGROUP_RETENTION environment variable so that this can be overridden. We may want this to be exposed in some other way, but for now it felt like a reasonable way to do it.

Pre-merge checklist

  • Does this require an update to the docs? Yes
  • Does this require a changelog entry? Yes, and should highlight that it will update existing tests

@bernardobridge bernardobridge requested a review from a team January 26, 2024 13:41
@hassy
Copy link
Member

hassy commented Jan 31, 2024

6 months sounds very reasonable. LGTM!

@bernardobridge bernardobridge merged commit cb320f9 into main Feb 2, 2024
18 checks passed
@bernardobridge bernardobridge deleted the bernardobridge/oss-18-put-cloudwatch-logs-retention-policies-for-aws-tests branch February 2, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants