fix(fargate): convert to posix paths before sending files to s3 #2431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-run-when-custom-js-is-in-a-separate
|
Windows test passing, confirming the fix: https://github.com/artilleryio/artillery/actions/runs/7573880065/job/20627137077 (was failing before) |
bernardobridge
deleted the
bernardobridge/oss-11-fargate-tests-will-not-run-when-custom-js-is-in-a-separate
branch
This was referenced Feb 5, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Paths to send to s3 are built based on a windows file system, but they are ran in ubuntu in the AWS containers. We need to account for that and convert the paths if needed.
Pre-merge checklist
This is for use by the Artillery team. Please leave this in if you're contributing to Artillery.