fix(core): make randomString deterministic and allow larger values #2342
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are two issues with the current
$randomString
function:I tried and benchmarked quite a few possible variations of the function (e.g. using
crypto.randomBytes
,lodash
utilities, etc). This solution was by far the fastest I got, even surpassing the existing function.Notes:
Testing
Pre-merge checklist
$randomString
and$randomNumber
to the docs as part of this