Fix Integration Tests #3600
Merged
Fix Integration Tests #3600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
May 18, 2024 17:24
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
d80tb7
commented
May 18, 2024
| @@ -201,9 +201,6 @@ func LocalDev(arg string) error { | |||
| mg.Deps(BootstrapTools) | |||
| fmt.Println("Time to bootstrap tools:", time.Since(timeTaken)) | |||
|
|
|||
| // Set the Executor Update Frequency to 1 second for local development | |||
There was a problem hiding this comment.
this was having no effect
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
robertdavidsmith
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARMADA_SCHEDULING_EXECUTORUPDATEFREQUENCYwas being set in the magefile where it was having no effect. As a result executor state was only being updated every 60 seconds which meant that jobs were being rejected as state had not propagated. This change movesARMADA_SCHEDULING_EXECUTORUPDATEFREQUENCYto be set as part of the docker compose where it is correctly applied.I've also tweaked some other values here which are more sensible defaults.