Use standardlogger when initialising new logger entries #3592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you use logrus.New() you lose all the formatting we've applied to the logger and just get the default We should use logrus.StandardLogger() - which we already do in most place - to maintain our formatting changes on new logger entries This is particularly noticeable on context based loggers (which the scheduler uses), as they don't have millisecond precision like they should Signed-off-by: JamesMurkin <jamesmurkin@hotmail.com>
Signed-off-by: JamesMurkin <jamesmurkin@hotmail.com>
…m/G-Research/armada into fix_context_logger_initialisation
masipauskas
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use logrus.New() you lose all the formatting we've applied to the logger and just get the default
We should use logrus.StandardLogger() - which we already do in most place - to maintain our formatting changes on new logger entries
This is particularly noticeable on context based loggers (which the scheduler uses), as they don't have millisecond precision like they should