Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make rand/getrandom dependency explicit with a feature #37

Merged
merged 3 commits into from Jan 14, 2022

Commits on Oct 26, 2021

  1. make rand/getrandom dependency explicit with a feature

    In the effort to make the arkworks framework available for compilation
    in wasm environment, we need to make ``getrandom`` indirect dependency an
    opt-in feature.
    ``rand/std`` feature triggers the dependency over ``getrandom``, so it can't be
    included in the ``std`` feature. It must be separated in an extra
    feature that we named ``getrandom``
    Giulio Ministeri committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    d6c9787 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2021

  1. setting resolver "2" to fix no-std build error

    getrandom being a dev-dependency makes cargo trying to include it in the
    build even when we are trying to build with no-std.
    Setting the resolver = "2" fixes the issue as Cargo is forced to
    recompute all the dependencies.
    Giulio Ministeri committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    b2013e1 View commit details
    Browse the repository at this point in the history
  2. cargo fmt

    Giulio Ministeri committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    440828c View commit details
    Browse the repository at this point in the history