Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve algebra structure #665

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Improve algebra structure #665

wants to merge 5 commits into from

Conversation

Pratyush
Copy link
Member

Description

Adds multiplicative groups to match the additive group structure, and moves these basic traits to a new crate.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@Pratyush Pratyush requested review from a team as code owners July 24, 2023 15:36
@Pratyush Pratyush requested review from mmagician and weikengchen and removed request for a team July 24, 2023 15:36
@Pratyush Pratyush marked this pull request as draft July 24, 2023 15:36
@mmaker mmaker marked this pull request as ready for review July 24, 2023 18:07
@Pratyush
Copy link
Member Author

@mmaker I have quite a few local changes which might conflict with your commits, so I think it might be better for me to push those before we fix the compiler errors.

@mmaker
Copy link
Member

mmaker commented Jul 24, 2023 •
edited

whoops, alright sorry about that! Feel free to force-push

@mmaker
Copy link
Member

mmaker commented Jul 29, 2023 •
edited

@Pratyush sweet, let me know if you need to offload some other tasks before this gets reviewed

@weikengchen
Copy link
Member

@Pratyush this PR is still draft, right?

@Pratyush Pratyush mentioned this pull request Aug 23, 2023
Open
This was linked to issues Sep 6, 2023
ark_ff::batch_inversion<F: Field> should be F::batch_inversion where F: Field #671
Open
create new ark-group crate #591
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmagician mmagician Awaiting requested review from mmagician mmagician is a code owner automatically assigned from arkworks-rs/maintainers

@weikengchen weikengchen Awaiting requested review from weikengchen weikengchen is a code owner automatically assigned from arkworks-rs/maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ark_ff::batch_inversion<F: Field> should be F::batch_inversion where F: Field create new ark-group crate
3 participants
@Pratyush @mmaker @weikengchen