Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(argo-cd): Added a comment how to pass values into argocd-cm ConfigMap #3177

Merged
merged 3 commits into from
Feb 23, 2025

Conversation

yu-croco
Copy link
Collaborator

@yu-croco yu-croco commented Feb 22, 2025

We cannot describe all of values for argocd-cm ConfigMap in values.yaml, so I added a comment how to set values.

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…figMap

Signed-off-by: yu-croco <yu.croco@gmail.com>
@yu-croco yu-croco marked this pull request as ready for review February 22, 2025 09:59
@yu-croco yu-croco changed the title chore(argo-cd): Added a comment how to pass values into argocd-cm ConfigMap doc(argo-cd): Added a comment how to pass values into argocd-cm ConfigMap Feb 22, 2025
@yu-croco yu-croco changed the title doc(argo-cd): Added a comment how to pass values into argocd-cm ConfigMap docs(argo-cd): Added a comment how to pass values into argocd-cm ConfigMap Feb 22, 2025
@mkilchhofer
Copy link
Member

Maybe we can also add a note inside the README?

maybe directly on this line?

@github-actions github-actions bot added size/S and removed size/XS labels Feb 23, 2025
Signed-off-by: yu-croco <yu.croco@gmail.com>
@yu-croco
Copy link
Collaborator Author

@mkilchhofer
Thank you for your review. I added a commit for it. 😄
ebf1717

@mbevc1 mbevc1 merged commit f265958 into argoproj:main Feb 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants