feat(argo-cd): Update to Argo CD 2.14 #3155
Merged
+2,257
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>
Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>
Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>
Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>
mkilchhofer
commented
Feb 3, 2025
mkilchhofer
commented
Feb 3, 2025
| @@ -119,7 +119,8 @@ global: | |||
| priorityClassName: "" | |||
|
|
|||
| # -- Default node selector for all components | |||
| nodeSelector: {} | |||
| nodeSelector: | |||
| kubernetes.io/os: linux | |||
There was a problem hiding this comment.
Breaking change yes/no ?
Opinions from other maintainers ?
Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>
Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>
Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>
Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>
Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>
mkilchhofer
requested review from
mbevc1,
yu-croco,
jmeridth,
pdrastil and
tico24
as code owners
mbevc1
previously approved these changes
Feb 4, 2025
Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>
tico24
approved these changes
Feb 4, 2025
yu-croco
approved these changes
Feb 4, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a late-night draft (😪) to replace the PR filed by Renovate:
Note to reviewers:
Metrics customization is still open.I'd like to implement it in another PR, if you are okay with that?Basics are now there. But ServiceMonitor is still open.
Checklist: