fix macos runners #1040
Merged
fix macos runners #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: crflynn <flynn@simplebet.io>
crflynn
requested review from
flaviuvadan,
samj1912 and
elliotgunton
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1040 +/- ##
=======================================
+ Coverage 81.7% 81.8% +0.1%
=======================================
Files 54 56 +2
Lines 4208 4228 +20
Branches 889 892 +3
=======================================
+ Hits 3439 3461 +22
+ Misses 574 571 -3
- Partials 195 196 +1 ☔ View full report in Codecov by Sentry. |
samj1912
added
semver:patch
Signed-off-by: Sambhav Kothari <sambhavs.email@gmail.com>
Signed-off-by: Sambhav Kothari <sambhavs.email@gmail.com>
|
@crflynn Thanks for the fix. I'm going to limit it to Python 3.11 for now. Will add 3.12 in another PR along with Linux. |
samj1912
approved these changes
Apr 25, 2024
|
Thank you @crflynn! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description of PR
actions/runner-images#9770
With macos-latest moving from macos-12 to macos-14, there are fewer available python versions.
This PR pins the previous macos-latest runner to macos-12 and adds entries for python 3.11 and 3.12 available on macos-14.
Also, it looks like the required status checks need to be updated.