Review #121078 #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not have any cached partitions available on Kubelet start with an empty container storage in CRI-O. This means that the error log message is not actually an error and more an information. This means we now pre-filter those cases and do not `klog.ErrorS` any more. This helps to avoid log spamming in huge clusters. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
Signed-off-by: Harshal Patil <harpatil@redhat.com> Co-authored-by: Ed Bartosh <eduard.bartosh@intel.com>
Signed-off-by: penguin <lihan.zhou@daocloud.io>
Signed-off-by: twelcon <mastermind12210@gmail.com>
Signed-off-by: twelcon <mastermind12210@gmail.com>
Signed-off-by: twelcon <mastermind12210@gmail.com>
kuberenetes >>> kubernetes
All runtimes are remote now, which is one of the last artifacts from dockershim removal. We can mention that we fallback to the runtime endpoint for the image endpoint, though. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
Signed-off-by: twelcon <mastermind12210@gmail.com>
Signed-off-by: Daman Arora <aroradaman@gmail.com>
Logistically, changes in the CRI require approval of members of the associated CRI communities to sign-onto implementing them. This relationship could be more formal, as this PR proposes. The current set of people is chosen as top-level approvers of two major CRI implementations, all of whom also regularly participate in SIG-Node and are not themselves already sig-node-approvers. Signed-off-by: Peter Hunt <pehunt@redhat.com>
Signed-off-by: Liang Deng <283304489@qq.com>
take on new name, to clarify scope Signed-off-by: Peter Hunt <pehunt@redhat.com>
Signed-off-by: Tarun Gupta Akirala <takirala@users.noreply.github.com>
…rectives and LegacyServiceAccountTokenNoAutoGeneration
Signed-off-by: bzsuni <bingzhe.sun@daocloud.io>
Rename the apiserver_request_body_sizes metric to apiserver_request_body_size_bytes to conform with Prometheus best practices. This can be done safely without deprecation because that metric wasn't registered before. Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
Adapting the tests and reverting kubernetes#103429 Carry-over from kubernetes#117881 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
This removes deprecated sets.String and sets.Int - replace sets.String with sets.Set[string] - replace sets.Int with sets.Set[int] - replace sets.NewString with sets.New[string] - replace sets.NewInt with sets.New[int] - replace sets.(OLD).List with sets.List(NEW)
Add a test case of create with rv set. Signed-off-by: Siyuan Zhang <sizhang@google.com>
fix: typo in staging/src/k8s.io/cri-api/pkg/apis/runtime/v1/api.proto
…fixup kubelet: fix log when using --reserved-cpus
Fix PersistentVolumeStatus & PersistentVolumeClaimStatus e2e test flake
…zserver proxy healthz server for dualstack clusters
Introducing Sleep Action for PreStop Hook
…pDiscoveryFailed client-go: chore: implement `Is` interface for `ErrGroupDiscoveryFailed`
…extensions/ratcheting-factor-correlation CRDValidationRatcheting: Factor object correlation and comparison into reusable component
as that seems more in line with the intention of these files Signed-off-by: Peter Hunt <pehunt@redhat.com>
k8s.io/apiserver/storage: add a new TestCreate case.
fix limitrange flaky test
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
remove GAed FG DownwardAPIHugePages
…2v3-config Decouple openapi v2v3 config
…ot_equal remove deprecated framework.ExpectNotEqual for node
…owners cri-api: compress OWNERS files
Keep PLEG interruptions in a separate interface
…ic-pods-name add validation for static pods to have a name
…o-mailru/easyjson Track unmaintained repo - mailru/easyjson
aramase
force-pushed
the
aramase/f/kep_3331_cel_integration
branch
3 times, most recently
from
f0f41ea
to
ae0033d
Compare
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
aramase
force-pushed
the
aramase/f/kep_3331_cel_integration
branch
from
ae0033d
to
c1b1808
Compare
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
aramase
force-pushed
the
aramase/f/kep_3331_cel_integration
branch
from
c1b1808
to
f2dc910
Compare
aramase
pushed a commit
that referenced
this pull request
Oct 31, 2023
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com> fix (#2) Signed-off-by: Monis Khan <mok@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review of kubernetes#121078