Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add configuration info for flags not supported by inputs #296

Merged
merged 2 commits into from Jan 11, 2024

Conversation

DmitriyLewen
Copy link
Contributor

Description

There are flags not supported by inputs.
We need to write about ways to configure these flags by ENVs and config file.

Related Issues

@DmitriyLewen DmitriyLewen marked this pull request as ready for review January 11, 2024 04:41
@DmitriyLewen
Copy link
Contributor Author

Are tests broken?
I changed only README.MD file.

@simar7
Copy link
Member

simar7 commented Jan 11, 2024

Are tests broken?
I changed only README.MD file.

Yes they are. See #294 for details.

Would you have some cycles to work on that by any chance? It would be nice to get them fixed.

@simar7 simar7 self-requested a review January 11, 2024 22:12
Copy link
Member

@simar7 simar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR, this looks great!

@simar7 simar7 merged commit 0b9d17b into aquasecurity:master Jan 11, 2024
1 of 2 checks passed
@DmitriyLewen DmitriyLewen deleted the docs/other-flags branch January 12, 2024 01:25
@DmitriyLewen
Copy link
Contributor Author

Yes they are. See #294 for details.
Would you have some cycles to work on that by any chance? It would be nice to get them fixed.

I will write into this issue if i have time for it.

juanjjaramillo pushed a commit to newrelic/helm-charts that referenced this pull request Feb 12, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[aquasecurity/trivy-action](https://togithub.com/aquasecurity/trivy-action)
| action | minor | `0.16.1` -> `0.17.0` |

---

### Release Notes

<details>
<summary>aquasecurity/trivy-action (aquasecurity/trivy-action)</summary>

###
[`v0.17.0`](https://togithub.com/aquasecurity/trivy-action/releases/tag/0.17.0)

[Compare
Source](https://togithub.com/aquasecurity/trivy-action/compare/0.16.1...0.17.0)

##### What's Changed

- docs: add configuration info for flags not supported by inputs by
[@&#8203;DmitriyLewen](https://togithub.com/DmitriyLewen) in
[aquasecurity/trivy-action#296
- fix: Fix `skip-files` and `hide-progress` options not being applied
when using Sarif report format by
[@&#8203;simao-silva](https://togithub.com/simao-silva) in
[aquasecurity/trivy-action#297
- Upgrades Trivy from 0.48.1 to v0.49.0 by
[@&#8203;kderck](https://togithub.com/kderck) in
[aquasecurity/trivy-action#304

##### New Contributors

- [@&#8203;simao-silva](https://togithub.com/simao-silva) made their
first contribution in
[aquasecurity/trivy-action#297

**Full Changelog**:
aquasecurity/trivy-action@0.16.1...0.17.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/newrelic/helm-charts).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(input): add path to secret config file
2 participants