Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable APT coin <-> FA mapping in genesis #13296

Merged
merged 1 commit into from
May 16, 2024

Conversation

igor-aptos
Copy link
Contributor

Description

devnet should have it enabled by default.

extracting from not-yet-reviewed #13194

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented May 16, 2024

⏱️ 18h 47m total CI duration on this PR
Job Cumulative Duration Recent Runs
forge-framework-upgrade-test / forge 4h 49m 🟩🟩🟥🟩
rust-smoke-tests 2h 42m 🟩🟩🟩
windows-build 1h 44m 🟩🟩🟩
rust-targeted-unit-tests 1h 14m 🟥🟩🟩
execution-performance / single-node-performance 1h 14m 🟩🟥🟩
rust-move-unit-coverage 1h 3m 🟩🟩🟩
forge-e2e-test / forge 58m 🟩🟩🟩🟩
forge-compat-test / forge 55m 🟩🟩🟩🟩
rust-images / rust-all 51m 🟩🟩🟩🟩
rust-move-tests 46m 🟩🟩🟩
cli-e2e-tests / run-cli-tests 30m 🟥🟩🟩🟥
rust-lints 25m 🟩🟩🟩
run-tests-main-branch 24m 🟩🟩🟩🟩 (+1 more)
test-target-determinator 14m 🟩🟩🟩🟩
rust-build-cached-packages 12m 🟩🟩🟩
check 12m 🟩🟩🟩
execution-performance / test-target-determinator 10m 🟩🟩🟩
general-lints 9m 🟩🟩🟩🟩🟩
check-dynamic-deps 7m 🟩🟩🟩🟩🟩
node-api-compatibility-tests / node-api-compatibility-tests 3m 🟩🟩🟩🟩
semgrep/ci 2m 🟩🟩🟩🟩🟩
file_change_determinator 1m 🟩🟩🟩🟩🟩 (+1 more)
file_change_determinator 53s 🟩🟩🟩🟩🟩
file_change_determinator 49s 🟩🟩🟩🟩
permission-check 24s 🟩🟩🟩🟩🟩 (+1 more)
permission-check 19s 🟩🟩🟩🟩🟩 (+1 more)
permission-check 17s 🟩🟩🟩🟩🟩 (+1 more)
permission-check 13s 🟩🟩🟩🟩🟩 (+1 more)
permission-check 12s 🟩🟩🟩🟩
determine-docker-build-metadata 5s 🟩🟩🟩🟩

🚨 3 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
cli-e2e-tests / run-cli-tests 9m 7m +39%
rust-targeted-unit-tests 24m 20m +22%
windows-build 31m 39m -21%

settingsfeedbackdocs ⋅ learn more about trunk.io

@igor-aptos igor-aptos requested a review from zekun000 May 16, 2024 06:10
@igor-aptos igor-aptos force-pushed the igor/enable_apt_coin_fa_mapping_in_genesis branch from 10fe989 to 6bd7ca1 Compare May 16, 2024 06:15
@igor-aptos igor-aptos enabled auto-merge (squash) May 16, 2024 06:19

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.5%. Comparing base (8c6963d) to head (7bcbf54).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13296   +/-   ##
=======================================
  Coverage    57.5%    57.5%           
=======================================
  Files         832      832           
  Lines      198522   198522           
=======================================
  Hits       114269   114269           
  Misses      84253    84253           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@igor-aptos igor-aptos force-pushed the igor/enable_apt_coin_fa_mapping_in_genesis branch from 6bd7ca1 to dcbe7ab Compare May 16, 2024 15:03

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@igor-aptos igor-aptos force-pushed the igor/enable_apt_coin_fa_mapping_in_genesis branch from dcbe7ab to 53ec8c3 Compare May 16, 2024 16:49

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@igor-aptos igor-aptos force-pushed the igor/enable_apt_coin_fa_mapping_in_genesis branch from 53ec8c3 to 7bcbf54 Compare May 16, 2024 17:33

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 7bcbf54df1a32d83fec7aaeb198e28bac9b94c37

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 7bcbf54df1a32d83fec7aaeb198e28bac9b94c37 (PR)
1. Check liveness of validators at old version: 01b24e7e3548382dd25440b39a0438a993387f12
compatibility::simple-validator-upgrade::liveness-check : committed: 4699.299832630329 txn/s, latency: 5599.393269589552 ms, (p50: 5000 ms, p90: 9500 ms, p99: 13100 ms), latency samples: 214400
2. Upgrading first Validator to new version: 7bcbf54df1a32d83fec7aaeb198e28bac9b94c37
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1448.7478615784955 txn/s, latency: 18760.17094375338 ms, (p50: 21600 ms, p90: 28300 ms, p99: 29500 ms), latency samples: 73960
3. Upgrading rest of first batch to new version: 7bcbf54df1a32d83fec7aaeb198e28bac9b94c37
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1631.397070951372 txn/s, latency: 16273.322786959474 ms, (p50: 19200 ms, p90: 22500 ms, p99: 23700 ms), latency samples: 88340
4. upgrading second batch to new version: 7bcbf54df1a32d83fec7aaeb198e28bac9b94c37
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3433.343534023123 txn/s, latency: 9134.96384997081 ms, (p50: 9900 ms, p90: 11700 ms, p99: 12200 ms), latency samples: 137040
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 7bcbf54df1a32d83fec7aaeb198e28bac9b94c37 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 7bcbf54df1a32d83fec7aaeb198e28bac9b94c37

two traffics test: inner traffic : committed: 7714.352967387171 txn/s, latency: 5079.997429224895 ms, (p50: 5000 ms, p90: 5800 ms, p99: 10500 ms), latency samples: 3331680
two traffics test : committed: 99.92157870693346 txn/s, latency: 1927.3692307692309 ms, (p50: 1800 ms, p90: 2200 ms, p99: 6300 ms), latency samples: 1820
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.203, avg: 0.202", "QsPosToProposal: max: 0.254, avg: 0.233", "ConsensusProposalToOrdered: max: 0.458, avg: 0.421", "ConsensusOrderedToCommit: max: 0.382, avg: 0.370", "ConsensusProposalToCommit: max: 0.807, avg: 0.791"]
Max round gap was 1 [limit 4] at version 1680174. Max no progress secs was 4.431851 [limit 15] at version 1680174.
Test Ok

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite framework_upgrade success on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 7bcbf54df1a32d83fec7aaeb198e28bac9b94c37

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 7bcbf54df1a32d83fec7aaeb198e28bac9b94c37 (PR)
Upgrade the nodes to version: 7bcbf54df1a32d83fec7aaeb198e28bac9b94c37
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1232.9239435630768 txn/s, submitted: 1237.012047140329 txn/s, failed submission: 4.088103577252254 txn/s, expired: 4.088103577252254 txn/s, latency: 2610.6480592939342 ms, (p50: 2100 ms, p90: 4500 ms, p99: 8700 ms), latency samples: 102540
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1115.8592642874905 txn/s, submitted: 1117.7048036950364 txn/s, failed submission: 1.845539407545984 txn/s, expired: 1.845539407545984 txn/s, latency: 2823.669319826339 ms, (p50: 2100 ms, p90: 4800 ms, p99: 8100 ms), latency samples: 96740
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 7bcbf54df1a32d83fec7aaeb198e28bac9b94c37 passed
Upgrade the remaining nodes to version: 7bcbf54df1a32d83fec7aaeb198e28bac9b94c37
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1094.7008770519503 txn/s, submitted: 1096.0954004622074 txn/s, failed submission: 1.3945234102572615 txn/s, expired: 1.3945234102572615 txn/s, latency: 2859.565212314225 ms, (p50: 2700 ms, p90: 4500 ms, p99: 6300 ms), latency samples: 94200
Test Ok

@igor-aptos igor-aptos merged commit 0d6739a into main May 16, 2024
50 of 54 checks passed
@igor-aptos igor-aptos deleted the igor/enable_apt_coin_fa_mapping_in_genesis branch May 16, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants