Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max-tps option to aptos node analyze-validator-performance cli #13290

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

igor-aptos
Copy link
Contributor

cargo run -p aptos -- node analyze-validator-performance --analyze-mode max-tps

Description

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented May 15, 2024

⏱️ 1h 30m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-targeted-unit-tests 31m 🟩🟥🟩
rust-lints 21m 🟩🟥🟩
rust-move-tests 14m 🟩🟩🟩
run-tests-main-branch 12m 🟩🟩🟩
general-lints 5m 🟩🟩🟩
check-dynamic-deps 4m 🟩🟩🟩
semgrep/ci 1m 🟩🟩🟩
file_change_determinator 33s 🟩🟩🟩
file_change_determinator 32s 🟩🟩🟩
permission-check 10s 🟩🟩🟩
permission-check 8s 🟩🟩🟩
permission-check 8s 🟩🟩🟩
permission-check 7s 🟩🟩🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-targeted-unit-tests 10m 19m -47%
rust-move-tests 3m 11m -71%

settingsfeedbackdocs ⋅ learn more about trunk.io

@igor-aptos igor-aptos force-pushed the igor/analyze_max_tps branch 2 times, most recently from 152fe8e to 3529540 Compare May 18, 2024 05:21
@igor-aptos
Copy link
Contributor Author

ping @sitalkedia , @bchocho for reviews here

@igor-aptos igor-aptos enabled auto-merge (squash) May 31, 2024 15:13

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Jun 3, 2024

✅ Forge suite compat success on a68e71c05caebf01504d4499110f3fba213fb53d ==> bba5e8249bf9016b8598841a3c9bfe97ae6b66ae

Compatibility test results for a68e71c05caebf01504d4499110f3fba213fb53d ==> bba5e8249bf9016b8598841a3c9bfe97ae6b66ae (PR)
1. Check liveness of validators at old version: a68e71c05caebf01504d4499110f3fba213fb53d
compatibility::simple-validator-upgrade::liveness-check : committed: 10960.810179705406 txn/s, latency: 3084.7796708429496 ms, (p50: 2600 ms, p90: 5400 ms, p99: 9600 ms), latency samples: 363960
2. Upgrading first Validator to new version: bba5e8249bf9016b8598841a3c9bfe97ae6b66ae
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 3373.3660299413173 txn/s, latency: 9274.314352053403 ms, (p50: 9600 ms, p90: 13900 ms, p99: 14200 ms), latency samples: 137820
3. Upgrading rest of first batch to new version: bba5e8249bf9016b8598841a3c9bfe97ae6b66ae
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 3417.554183333847 txn/s, latency: 9121.011425485962 ms, (p50: 9400 ms, p90: 13800 ms, p99: 14200 ms), latency samples: 138900
4. upgrading second batch to new version: bba5e8249bf9016b8598841a3c9bfe97ae6b66ae
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6388.796948094031 txn/s, latency: 5122.300698966745 ms, (p50: 4800 ms, p90: 8100 ms, p99: 9300 ms), latency samples: 230340
5. check swarm health
Compatibility test for a68e71c05caebf01504d4499110f3fba213fb53d ==> bba5e8249bf9016b8598841a3c9bfe97ae6b66ae passed
Test Ok

Copy link
Contributor

github-actions bot commented Jun 3, 2024

✅ Forge suite realistic_env_max_load success on bba5e8249bf9016b8598841a3c9bfe97ae6b66ae

two traffics test: inner traffic : committed: 8595.524515754938 txn/s, latency: 4566.70326991997 ms, (p50: 4500 ms, p90: 5400 ms, p99: 9600 ms), latency samples: 3711100
two traffics test : committed: 99.98881970207081 txn/s, latency: 2140.0337078651687 ms, (p50: 2000 ms, p90: 2200 ms, p99: 8200 ms), latency samples: 1780
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.217, avg: 0.205", "QsPosToProposal: max: 0.220, avg: 0.199", "ConsensusProposalToOrdered: max: 0.419, avg: 0.373", "ConsensusOrderedToCommit: max: 0.363, avg: 0.350", "ConsensusProposalToCommit: max: 0.732, avg: 0.724"]
Max round gap was 1 [limit 4] at version 1664525. Max no progress secs was 5.00932 [limit 15] at version 1664525.
Test Ok

Copy link
Contributor

github-actions bot commented Jun 3, 2024

✅ Forge suite framework_upgrade success on a68e71c05caebf01504d4499110f3fba213fb53d ==> bba5e8249bf9016b8598841a3c9bfe97ae6b66ae

Compatibility test results for a68e71c05caebf01504d4499110f3fba213fb53d ==> bba5e8249bf9016b8598841a3c9bfe97ae6b66ae (PR)
Upgrade the nodes to version: bba5e8249bf9016b8598841a3c9bfe97ae6b66ae
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1299.825465051469 txn/s, submitted: 1302.415696956463 txn/s, failed submission: 2.59023190499387 txn/s, expired: 2.59023190499387 txn/s, latency: 2432.8261865942027 ms, (p50: 1800 ms, p90: 4200 ms, p99: 6600 ms), latency samples: 110400
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1182.242652181853 txn/s, submitted: 1184.553977015053 txn/s, failed submission: 2.3113248332001035 txn/s, expired: 2.3113248332001035 txn/s, latency: 2606.921603128055 ms, (p50: 2000 ms, p90: 4300 ms, p99: 9000 ms), latency samples: 102300
5. check swarm health
Compatibility test for a68e71c05caebf01504d4499110f3fba213fb53d ==> bba5e8249bf9016b8598841a3c9bfe97ae6b66ae passed
Upgrade the remaining nodes to version: bba5e8249bf9016b8598841a3c9bfe97ae6b66ae
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1164.3721902793727 txn/s, submitted: 1167.8758177325703 txn/s, failed submission: 3.503627453197711 txn/s, expired: 3.503627453197711 txn/s, latency: 2697.9495787362084 ms, (p50: 2100 ms, p90: 4800 ms, p99: 9300 ms), latency samples: 99700
Test Ok

@igor-aptos igor-aptos merged commit fa93f07 into main Jun 3, 2024
51 checks passed
@igor-aptos igor-aptos deleted the igor/analyze_max_tps branch June 3, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants