-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jwk updates #13253
jwk updates #13253
Conversation
zjma
commented
May 11, 2024
•
edited
edited
- Pull some shared JWK logic out into a crate and make it a dependency of pepper service and jwk-consensus.
- Start fetching apple jwks in pepper service.
⏱️ 56m total CI duration on this PR
🚨 1 job on the last run was significantly faster/slower than expected
|
jwk::start_jwk_refresh_loop( | ||
"https://id.twitch.tv/oauth2", | ||
"https://id.twitch.tv/oauth2/keys", | ||
"https://appleid.apple.com", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So these are not on-chain?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not yet
Duration::from_secs(10), | ||
local_observation_tx.clone(), | ||
) | ||
.flat_map(|provider| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the flat_map
? You are mapping provider
to one value, not to an iterator over values no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like i meant filter_map
🤦
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
let mut interval = tokio::time::interval(fetch_interval); | ||
interval.set_missed_tick_behavior(MissedTickBehavior::Delay); | ||
let mut close_rx = close_rx.into_stream(); | ||
let my_addr = if cfg!(feature = "smoke-test") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this for? There are no comments on this function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
df5202c
to
d1e7e49
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|