New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dep] upgrade serde, serde-reflection and related deps #11137
Conversation
d2c4ee1
to
af4a30b
Compare
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
c6011f1
to
e140afd
Compare
fabda4f
to
f5defb3
Compare
a7522bf
to
3b2a326
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
3b2a326
to
8559fb7
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@@ -758,7 +756,6 @@ debug-assertions = true | |||
debug = true | |||
|
|||
[patch.crates-io] | |||
serde-reflection = { git = "https://github.com/aptos-labs/serde-reflection", rev = "839aed62a20ddccf043c08961cfe74875741ccba" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we did this to ensure that the Move repo used this as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. It wasn't overriding actually, so I thought it wasn't needed. Fixed it now by pointing dependency in move-bytecode-utils
crate to workspace.
Thanks for the stamp. I need to land this first: aptos-labs/aptos-indexer-processors#218.
8559fb7
to
59941c3
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
59941c3
to
738a738
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
0c23cbe
to
4b8cdf2
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
4b8cdf2
to
cd5973f
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
❌ Forge suite
|
Woo!!!!! |
Description
This PR upgrades
serde
andserde-reflection
crates. This change fixes aptos-core is stuck on serde < 1.0.53 due to a change in 1.0.53 that breaks testsuite/generate-format #10424 and makes serde upgradable again. It uses the new APIignore_aliases
introduced in our fork of serde-reflection support ignoring alias fields from trace registry serde-reflection#3 to ignore aliases inStructTag
struct.This PR also upgrades
proptest
tov1.4
and fixes test failures in aggregator tests.Upgrades
serde_json
and fixes related unit tests. Particularly, the latest version ofserde_json
extends the Serialize trait to include write_u128 fn, which has to be implemented to ensure that u128 are written as strings.Test Plan
Existing tests work after the upgrade.