feat: Updated deps_app/2 to support missing optional applications #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GRoguelon yes, can you please open a new PR that targets master on this repo? |
|
Directly submitted on jeremyjh#514 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up your PR you made on Dialyxir. I have tried to manage the issue mentioned by @josevalim.
The PR updates the
deps_app/2function in theDialyxir.Projectmodule inlib/dialyxir/project.exto handle different versions of Elixir. Added version checking for Elixir 1.15 or later, and adjusted the implementation accordingly. The changes ensure that thedeps_app/2function works correctly with the appropriate version of Elixir.I'm not totally sure if my change is backward compatible with previous versions of Elixir.