Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Puma spec helper methods #964

Merged
merged 1 commit into from
May 3, 2023
Merged

Refactor Puma spec helper methods #964

merged 1 commit into from
May 3, 2023

Commits on May 2, 2023

  1. Refactor Puma spec helper methods

    Collect all the Puma plugin state management in the `run_plugin` help,
    rather than spread it around the before and after blocks, and
    let-statements. This is the result of an attempt to make the test less
    fragile/brittle as it fails every once in a while on CI.
    
    Moving everything in the same helper, we're sure what needs to happen
    before each start and stop of the plugin and we're sure it always
    executes, even on failure.
    
    [skip changeset]
    tombruijn committed May 2, 2023
    Configuration menu
    Copy the full SHA
    d423ea1 View commit details
    Browse the repository at this point in the history