Refactor Puma spec helper methods #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collect all the Puma plugin state management in the `run_plugin` help, rather than spread it around the before and after blocks, and let-statements. This is the result of an attempt to make the test less fragile/brittle as it fails every once in a while on CI. Moving everything in the same helper, we're sure what needs to happen before each start and stop of the plugin and we're sure it always executes, even on failure. [skip changeset]
luismiramirez
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collect all the Puma plugin state management in the
run_pluginhelp, rather than spread it around the before and after blocks, and let-statements. This is the result of an attempt to make the test less fragile/brittle as it fails every once in a while on CI.Moving everything in the same helper, we're sure what needs to happen before each start and stop of the plugin and we're sure it always executes, even on failure.
[skip changeset]