Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: CodeQLの問題を修正 #169

Merged
merged 13 commits into from
May 6, 2022
Merged

ci: CodeQLの問題を修正 #169

merged 13 commits into from
May 6, 2022

Conversation

m1sk9
Copy link
Contributor

@m1sk9 m1sk9 commented May 5, 2022

Issue: No Issue

Type of Change:

CIの修正

Cause of the Problem (問題の原因)

CodeQL CIで以下の警告が報告されていた:

1 issue was detected with this workflow: Using on.push.paths-ignore can prevent Code Scanning annotating new alerts in your pull requests.

これについて github/codeql-action#283Code Securityに関するGitHub Docs を見てみると GitHub Actions の設定ファイル(workflows/ 配下) でパスの除外(paths-ignore)を行うのはベストプラクティスではないことがわかった

Dealing with Problems (問題への対処)

github/codeql-action#283 を見ると codeql-action では独自の設定ファイルがあり、それを jobs.steps.with.config-file にパスとして渡してあげることで対処

Details of implementation (実施内容)

  • GitHub Actionsの設定ファイルから on.push.paths-ignoreon.pull_request.paths-ignore を削除
  • 独自の設定ファイル ( codeql-config.yml ) を追加
     - src/ 配下にあるファイルに対して実行されるように
     - Markdownの変更には実行されないように

@m1sk9 m1sk9 added the bug label May 5, 2022
@m1sk9 m1sk9 requested a review from MikuroXina May 5, 2022 05:23
@m1sk9 m1sk9 self-assigned this May 5, 2022
@m1sk9 m1sk9 changed the title ci: MarkdownファイルのプッシュでもCIが走るように fix: CodeQLの問題を修正 May 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 5, 2022

Codecov Report

Merging #169 (f00d0dc) into main (5d45ab7) will not change coverage.
The diff coverage is n/a.

❗ Current head f00d0dc differs from pull request most recent head 64676a9. Consider uploading reports for the commit 64676a9 to get more accurate results

@@           Coverage Diff           @@
##             main     #169   +/-   ##
=======================================
  Coverage   48.06%   48.06%           
=======================================
  Files          35       35           
  Lines         749      749           
  Branches      123      123           
=======================================
  Hits          360      360           
  Misses        272      272           
  Partials      117      117           
Flag Coverage Δ
unittests 48.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d45ab7...64676a9. Read the comment docs.

@m1sk9 m1sk9 changed the title fix: CodeQLの問題を修正 ci: CodeQLの問題を修正 May 5, 2022
@m1sk9 m1sk9 enabled auto-merge (squash) May 5, 2022 05:25
@m1sk9 m1sk9 marked this pull request as draft May 5, 2022 05:28
auto-merge was automatically disabled May 5, 2022 05:28

Pull request was converted to draft

@m1sk9 m1sk9 closed this May 5, 2022
@m1sk9 m1sk9 reopened this May 5, 2022
@m1sk9 m1sk9 marked this pull request as ready for review May 5, 2022 05:52
@m1sk9 m1sk9 enabled auto-merge (squash) May 6, 2022 15:16
@m1sk9 m1sk9 merged commit b9c5fa2 into main May 6, 2022
@m1sk9 m1sk9 deleted the fix/CI-CodeQL branch May 6, 2022 15:23
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2022

🎉 This PR is included in version 1.12.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants