-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest NIO with updated protocol negotiation SPI #414
Conversation
Signed-off-by: Si Beaumont <beaumont@apple.com>
@simonjbeaumont There are a bunch of warnings now since we deprecated something and we have to migrate those API usages as well. |
Signed-off-by: Si Beaumont <beaumont@apple.com>
My daily Android CI, which builds trunk NIO HTTP/2 against trunk NIO, just broke because of that NIO pull. I can confirm that this pull fixes it on Android. |
@swift-server-bot test this please |
@simonjbeaumont any idea what's happening with the api breakage build? |
Yes, the API checker relies on being able to compile the previous commit, which is failing because of the SPI change, which is fixed in this PR. So we have a chicken-egg issue here.
|
Oh good catch. Thanks! |
Motivation
A recent PR to apple/swift-nio#2497 adjusted the SPI for protocol negotiation.
Modifications
NIOTypedApplicationProtocolNegotiationHandler
.Result
Compiles again with latest NIO.