Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parent channel read() call on HTTP2StreamChannel initialization causing incorrect order of inbound HTTP2Frames #413

Merged
merged 1 commit into from
Jul 28, 2023

Commits on Jul 27, 2023

  1. Fix parent channel read() call on HTTP2StreamChannel initializati…

    …on causing incorrect order of inbound `HTTP2Frame`s
    
    Motivation:
    
    Make sure the order of `HTTP2Frame`s that are fired through the pipeline of a `HTTP2StreamChannel` by `HTTP2CommonInboundStreamMultiplexer` is correct when a `read()` call on the parent channel synchronously causes further frames to be processed.
    
    Modifications:
    
    Reorder calls in `HTTP2CommonInboundStreamMultiplexer.receivedFrame(frame:context:multiplexer)` so that initial header frame is buffered and processed first.
    
    Result:
    
    Resolves apple#410 and makes newly added test case `HTTP2StreamMultiplexerTests.testMultiplexerFiresInitialFramesInCorrectOrder()` pass.
    qusc committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    e4d5e5c View commit details
    Browse the repository at this point in the history