Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional NIOAsyncChannel config #406

Merged
merged 4 commits into from
Jul 4, 2023
Merged

Add additional NIOAsyncChannel config #406

merged 4 commits into from
Jul 4, 2023

Commits on Jul 4, 2023

  1. Add additional NIOAsyncChannel config 

    Motivation:

Recent additions to pipeline configuration did not expose some of the
`NIOAsyncChannel` configuration.

Modifications:

Expose `backpressureStrategy`, `isOutboundHalfClosureEnabled`.

I think specific naming and object encapsulation for these parameters should be discussed
later before SPI is removed and we review the API as a whole.

Result:

Pipelie helpers for `NIOAsyncChannel` expose `backpressureStrategy`, `isOutboundHalfClosureEnabled`.
    @rnro
    rnro committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    c46c98f View commit details
    Browse the repository at this point in the history

  2. review comments, re-order parameters

    @rnro
    rnro committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    5d1584d View commit details
    Browse the repository at this point in the history

  3. review comments

    @rnro
    rnro committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    baa25d5 View commit details
    Browse the repository at this point in the history

  4. param reordering, missing docs comments

    @rnro
    rnro committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    49eb2f9 View commit details
    Browse the repository at this point in the history