Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest NIO with updated protocol negotiation SPI #414

Merged
merged 2 commits into from Aug 8, 2023

Conversation

simonjbeaumont
Copy link
Contributor

Motivation

A recent PR to apple/swift-nio#2497 adjusted the SPI for protocol negotiation.

Modifications

  • Bump minimum NIO version to 2.58.0
  • Update use of NIOTypedApplicationProtocolNegotiationHandler.

Result

Compiles again with latest NIO.

Signed-off-by: Si Beaumont <beaumont@apple.com>
@Lukasa Lukasa added the needs-no-version-bump For PRs that when merged do not need a bump in version number. label Aug 8, 2023
@FranzBusch
Copy link
Contributor

@simonjbeaumont There are a bunch of warnings now since we deprecated something and we have to migrate those API usages as well.

Signed-off-by: Si Beaumont <beaumont@apple.com>
@finagolfin
Copy link
Contributor

@Lukasa
Copy link
Contributor

Lukasa commented Aug 8, 2023

@swift-server-bot test this please

@Lukasa
Copy link
Contributor

Lukasa commented Aug 8, 2023

@simonjbeaumont any idea what's happening with the api breakage build?

@simonjbeaumont
Copy link
Contributor Author

simonjbeaumont commented Aug 8, 2023

@simonjbeaumont any idea what's happening with the api breakage build?

Yes, the API checker relies on being able to compile the previous commit, which is failing because of the SPI change, which is fixed in this PR. So we have a chicken-egg issue here.

13:55:24 [305/311] Compiling NIOHTTP2 HTTP2Stream.swift
13:55:24 /tmp/.check-api_DOZ6tg/repo/.build/x86_64-unknown-linux-gnu/apidiff/493897c4744de24fe7c48940c3654e41fb6673fc-checkout/Sources/NIOHTTP2/HTTP2PipelineHelpers.swift:503:27: error: no exact matches in call to initializer 
13:55:24         let alpnHandler = NIOTypedApplicationProtocolNegotiationHandler<NIONegotiatedHTTPVersion<HTTP1Output, HTTP2Output>>(eventLoop: self.eventLoop) { result in

@Lukasa
Copy link
Contributor

Lukasa commented Aug 8, 2023

Oh good catch. Thanks!

@Lukasa Lukasa merged commit 2bf5733 into apple:main Aug 8, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-no-version-bump For PRs that when merged do not need a bump in version number.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants