review comments

Sources/NIOHTTP2/HTTP2ChannelHandler+InlineStreamMultiplexer.swift

@@ -148,7 +148,7 @@ extension InlineStreamMultiplexer {
         self.commonStreamMultiplexer.createStreamChannel(multiplexer: .inline(self), streamStateInitializer)
     }
 
-    internal func createStreamChannel<Output>(_ initializer: @escaping NIOHTTP2Handler.StreamInitializerWithOutput<Output>) -> EventLoopFuture<Output> {
+    internal func createStreamChannel<Output>(_ initializer: @escaping NIOChannelInitializerWithOutput<Output>) -> EventLoopFuture<Output> {
         self.commonStreamMultiplexer.createStreamChannel(multiplexer: .inline(self), initializer)
     }
 }
@@ -239,7 +239,7 @@ extension NIOHTTP2Handler {
         }
 
         /// Create a stream channel initialized with the provided closure
-        public func createStreamChannel<OutboundStreamOutput>(_ initializer: @escaping NIOHTTP2Handler.StreamInitializerWithOutput<OutboundStreamOutput>) async throws -> OutboundStreamOutput {
+        public func createStreamChannel<OutboundStreamOutput>(_ initializer: @escaping NIOChannelInitializerWithOutput<OutboundStreamOutput>) async throws -> OutboundStreamOutput {
             return try await self.inlineStreamMultiplexer.createStreamChannel(initializer).get()
         }
 
@@ -264,7 +264,7 @@ extension NIOHTTP2Handler {
             isOutboundHalfClosureEnabled: Bool = false,
             inboundType: Inbound.Type = Inbound.self,
             outboundType: Outbound.Type = Outbound.self,
-            initializer: @escaping NIOHTTP2Handler.StreamInitializer
+            initializer: @escaping NIOChannelInitializer
         ) async throws -> NIOAsyncChannel<Inbound, Outbound> {
             return try await self.createStreamChannel { channel in
                 initializer(channel).flatMapThrowing { _ in

Sources/NIOHTTP2/HTTP2ChannelHandler.swift

@@ -23,7 +23,6 @@ public let nioDefaultSettings = [
     HTTP2Setting(parameter: .maxHeaderListSize, value: HPACKDecoder.defaultMaxHeaderListSize),
 ]
 
-
 /// ``NIOHTTP2Handler`` implements the HTTP/2 protocol for a single connection.
 ///
 /// This `ChannelHandler` takes a series of bytes and turns them into a sequence of ``HTTP2Frame`` objects.
@@ -988,23 +987,11 @@ extension NIOHTTP2Handler {
 
 extension NIOHTTP2Handler {
 #if swift(>=5.7)
-    /// The type of all `inboundStreamInitializer` callbacks.
-    public typealias StreamInitializer = @Sendable (Channel) -> EventLoopFuture<Void>
-    /// The type of all `connectionInitializer` callbacks.
-    public typealias ConnectionInitializer = @Sendable (Channel) -> EventLoopFuture<Void>
-    /// The type of `inboundStreamInitializer` callbacks which return non-void results.
-    public typealias StreamInitializerWithOutput<Output> = @Sendable (Channel) -> EventLoopFuture<Output>
-    /// The type of all `connectionInitializer` callbacks which return non-void results.
-    public typealias ConnectionInitializerWithOutput<Output> = @Sendable (Channel) -> EventLoopFuture<Output>
+    /// The type of all `inboundStreamInitializer` callbacks which do not need to return data.
+    public typealias StreamInitializer = NIOChannelInitializer
 #else
-    /// The type of all `inboundStreamInitializer` callbacks.
-    public typealias StreamInitializer = (Channel) -> EventLoopFuture<Void>
-    /// The type of all `connectionInitializer` callbacks.
-    public typealias ConnectionInitializer = (Channel) -> EventLoopFuture<Void>
-    /// The type of `inboundStreamInitializer` callbacks which return non-void results.
-    public typealias StreamInitializerWithOutput<Output> = (Channel) -> EventLoopFuture<Output>
-    /// The type of all `connectionInitializer` callbacks which return non-void results.
-    public typealias ConnectionInitializerWithOutput<Output> = (Channel) -> EventLoopFuture<Output>
+    /// The type of all `inboundStreamInitializer` callbacks which need to return data.
+    public typealias StreamInitializer = NIOChannelInitializer
 #endif
 
     /// Creates a new ``NIOHTTP2Handler`` with a local multiplexer. (i.e. using

Sources/NIOHTTP2/HTTP2CommonInboundStreamMultiplexer.swift

@@ -286,7 +286,7 @@ extension HTTP2CommonInboundStreamMultiplexer {
     internal func _createStreamChannel<Output>(
         _ multiplexer: HTTP2StreamChannel.OutboundStreamMultiplexer,
         _ promise: EventLoopPromise<Output>?,
-        _ streamStateInitializer: @escaping NIOHTTP2Handler.StreamInitializerWithOutput<Output>
+        _ streamStateInitializer: @escaping NIOChannelInitializerWithOutput<Output>
     ) {
         self.channel.eventLoop.assertInEventLoop()
 
@@ -307,7 +307,7 @@ extension HTTP2CommonInboundStreamMultiplexer {
     internal func createStreamChannel<Output>(
         multiplexer: HTTP2StreamChannel.OutboundStreamMultiplexer,
         promise: EventLoopPromise<Output>?,
-        _ streamStateInitializer: @escaping NIOHTTP2Handler.StreamInitializerWithOutput<Output>
+        _ streamStateInitializer: @escaping NIOChannelInitializerWithOutput<Output>
     ) {
         if self.channel.eventLoop.inEventLoop {
             self._createStreamChannel(multiplexer, promise, streamStateInitializer)
@@ -320,7 +320,7 @@ extension HTTP2CommonInboundStreamMultiplexer {
 
     internal func createStreamChannel<Output>(
         multiplexer: HTTP2StreamChannel.OutboundStreamMultiplexer,
-        _ streamStateInitializer: @escaping NIOHTTP2Handler.StreamInitializerWithOutput<Output>
+        _ streamStateInitializer: @escaping NIOChannelInitializerWithOutput<Output>
     ) -> EventLoopFuture<Output> {
         let promise = self.channel.eventLoop.makePromise(of: Output.self)
         self.createStreamChannel(multiplexer: multiplexer, promise: promise, streamStateInitializer)
@@ -426,11 +426,11 @@ internal protocol ChannelContinuation {
 @available(macOS 10.15, iOS 13.0, watchOS 6.0, tvOS 13.0, *)
 struct StreamChannelContinuation<Output>: ChannelContinuation {
     private var continuation: AsyncThrowingStream<Output, Error>.Continuation
-    private let inboundStreamInititializer: NIOHTTP2Handler.StreamInitializerWithOutput<Output>
+    private let inboundStreamInititializer: NIOChannelInitializerWithOutput<Output>
 
     private init(
         continuation: AsyncThrowingStream<Output, Error>.Continuation,
-        inboundStreamInititializer: @escaping NIOHTTP2Handler.StreamInitializerWithOutput<Output>
+        inboundStreamInititializer: @escaping NIOChannelInitializerWithOutput<Output>
     ) {
         self.continuation = continuation
         self.inboundStreamInititializer = inboundStreamInititializer
@@ -446,7 +446,7 @@ struct StreamChannelContinuation<Output>: ChannelContinuation {
     ///   have a `Output` corresponding to that `NIOAsyncChannel` type. Another example is in cases where there is
     ///   per-stream protocol negotiation where `Output` would be some form of `NIOProtocolNegotiationResult`.
     static func initialize(
-        with inboundStreamInititializer: @escaping NIOHTTP2Handler.StreamInitializerWithOutput<Output>
+        with inboundStreamInititializer: @escaping NIOChannelInitializerWithOutput<Output>
     ) -> (StreamChannelContinuation<Output>, NIOHTTP2InboundStreamChannels<Output>) {
         let (stream, continuation) = AsyncThrowingStream.makeStream(of: Output.self)
         return (StreamChannelContinuation(continuation: continuation, inboundStreamInititializer: inboundStreamInititializer), NIOHTTP2InboundStreamChannels(stream))