fix: Use WeakHashMap for caching proxy classes #2260
Merged
+42
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace ConcurrentHashMap with WeakHashMap wrapped with Collections.synchronizedMap to ensure thread-safety.
Auto81
requested review from
mykola-mokhnach,
SrinivasanTarget,
saikrishna321 and
valfirst
as code owners
valfirst
requested changes
Jan 20, 2025
...t/java/io/appium/java_client/pagefactory_tests/widget/tests/combined/CombinedWidgetTest.java
Outdated
Show resolved
Hide resolved
asolntsev
approved these changes
Jan 20, 2025
...t/java/io/appium/java_client/pagefactory_tests/widget/tests/combined/CombinedWidgetTest.java
Outdated
Show resolved
Hide resolved
|
Thank you @Auto81 Please sign the CLA and update the PR title to comply with conventional commit naming rules as well as styling/linter ones |
resolve PR comments
Update Helpers.java
remove unused import
re align formatting to original
Auto81
changed the title
valfirst
approved these changes
Jan 20, 2025
...t/java/io/appium/java_client/pagefactory_tests/widget/tests/combined/CombinedWidgetTest.java
Outdated
Show resolved
Hide resolved
...t/java/io/appium/java_client/pagefactory_tests/widget/tests/combined/CombinedWidgetTest.java
Outdated
Show resolved
Hide resolved
mykola-mokhnach
approved these changes
Jan 20, 2025
Update CombinedWidgetTest.java
|
Hi @Auto81, congrats: the Appium project wants to compensate you for this contribution! Please reply to this comment mentioning @jlipps and @KazuCocoa and sharing your OpenCollective account name, so that we can initiate payment! Or let us know if you decline to receive compensation via OpenCollective. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
Fix for #2247
Types of changes
Details
Expanded test asserts in CombinedWidgetTest, happy to move if better place.